Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visionOS CI #2747

Merged
merged 5 commits into from Jan 31, 2024
Merged

Add visionOS CI #2747

merged 5 commits into from Jan 31, 2024

Conversation

stephencelis
Copy link
Member

Should catch regressions in visionOS builds.

@stephencelis
Copy link
Member Author

That failure was expected. Just merged #2746 in to test the fix against this branch.

@peterbohac
Copy link
Contributor

Thanks! Glad to see this CI pipeline added :)

@jshier
Copy link
Contributor

jshier commented Jan 30, 2024

This may also be an opportunity to try the new macOS-14 builders (M1-based) for Xcode 15, for faster builds.

@stephencelis
Copy link
Member Author

This may also be an opportunity to try the new macOS-14 builders (M1-based) for Xcode 15, for faster builds.

Just saw that 😄 We'll give it a shot on another PR once this is merged.

@stephencelis
Copy link
Member Author

@jshier Taking them for a test run on CasePaths and 15 minutes into a build still waiting for a runner to pick up the job: https://github.com/pointfreeco/swift-case-paths/actions/runs/7719232654/job/21042112183

Probably can't switch till they've been rolled out a bit more thoroughly.

@jshier
Copy link
Contributor

jshier commented Jan 31, 2024

@jshier Taking them for a test run on CasePaths and 15 minutes into a build still waiting for a runner to pick up the job: https://github.com/pointfreeco/swift-case-paths/actions/runs/7719232654/job/21042112183

Probably can't switch till they've been rolled out a bit more thoroughly.

Too bad. Also, since they're macOS 14 images, you likely won't be able to run Xcode 14 builds anyway, so those can stay on the older runners.

(Wish GHA had availability graphs like other providers, just so we could see how backed up they are.)

@jshier
Copy link
Contributor

jshier commented Jan 31, 2024

Actually, it looks like all macOS runners are waiting?

@stephencelis
Copy link
Member Author

@jshier Yeah seeing everything queued here, too. I wonder if this is just affecting the @pointfreeco org or if it's site wide?

@stephencelis
Copy link
Member Author

Too bad. Also, since they're macOS 14 images, you likely won't be able to run Xcode 14 builds anyway, so those can stay on the older runners.

Oh, and according to their runner images, macOS 14 does come installed with Xcode 14:

https://github.com/actions/runner-images/blob/main/images/macos/macos-14-Readme.md

Was just waiting to see if it actually worked.

@jshier
Copy link
Contributor

jshier commented Jan 31, 2024

Oh, and according to their runner images, macOS 14 does come installed with Xcode 14:

https://github.com/actions/runner-images/blob/main/images/macos/macos-14-Readme.md

Odd, given Apple specifically blocks you from running Xcode 14 on macOS 14. I wonder if their docs are just out of date. Guess we'll see.

@stephencelis stephencelis merged commit 96ce68d into main Jan 31, 2024
7 checks passed
@stephencelis stephencelis deleted the visionos-ci branch January 31, 2024 20:07
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Feb 1, 2024
…ure to from: "1.7.2" (#889)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[pointfreeco/swift-composable-architecture](https://togithub.com/pointfreeco/swift-composable-architecture)
| patch | `from: "1.7.1"` -> `from: "1.7.2"` |

---

### Release Notes

<details>
<summary>pointfreeco/swift-composable-architecture
(pointfreeco/swift-composable-architecture)</summary>

###
[`v1.7.2`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.7.2)

[Compare
Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.7.1...1.7.2)

#### What's Changed

- Fixed: A visionOS build regression introduced in 1.7.1 has been fixed
(thanks [@&#8203;peterbohac](https://togithub.com/peterbohac),
[pointfreeco/swift-composable-architecture#2746).
- Fixed: visionOS-related warnings around observation have been fixed
([pointfreeco/swift-composable-architecture#2752).
- Infrastructure: CI now runs against visionOS
([pointfreeco/swift-composable-architecture#2747).

#### New Contributors

- [@&#8203;peterbohac](https://togithub.com/peterbohac) made their first
contribution in
[pointfreeco/swift-composable-architecture#2746

**Full Changelog**:
pointfreeco/swift-composable-architecture@1.7.1...1.7.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants