Fix regression: remove BindableAction dynamic case lookup
#2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrandonw
approved these changes
Mar 5, 2024
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Mar 5, 2024
…ure to from: "1.9.2" (#949) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [pointfreeco/swift-composable-architecture](https://togithub.com/pointfreeco/swift-composable-architecture) | patch | `from: "1.9.1"` -> `from: "1.9.2"` | --- ### Release Notes <details> <summary>pointfreeco/swift-composable-architecture (pointfreeco/swift-composable-architecture)</summary> ### [`v1.9.2`](https://togithub.com/pointfreeco/swift-composable-architecture/releases/tag/1.9.2) [Compare Source](https://togithub.com/pointfreeco/swift-composable-architecture/compare/1.9.1...1.9.2) #### What's Changed - Fixed: The `BindableAction` dynamic case lookup added in 1.9 led to a regression in compile time performance that could break downstream builds. This has been reverted ([pointfreeco/swift-composable-architecture#2886). - Fixed: Support swift-syntax 510 ([pointfreeco/swift-composable-architecture#2884). - Infrastructure: Add Links to Migration Guides in README (thanks [@​jshier](https://togithub.com/jshier), [pointfreeco/swift-composable-architecture#2877). - Infrastructure: Fixed the article of tree-based navigation (thanks [@​takehilo](https://togithub.com/takehilo), [pointfreeco/swift-composable-architecture#2882). - Infrastructure: Leverage dynamic case writability in example code ([pointfreeco/swift-composable-architecture#2885). **Full Changelog**: pointfreeco/swift-composable-architecture@1.9.1...1.9.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TCA 1.9 introduced a shorthand for accessing a case key path of a particular binding state directly:
This unfortunately regressed type-checking performance of downstream projects, which could lead to builds beginning to fail.
Because this introduction was a breaking change to some projects, we will remove it and instead folks should chain in from
\.binding: