Add dump format for Duration #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Jun 20, 2023
| extension Character: CustomDumpRepresentable { | ||
| public var customDumpValue: Any { | ||
| String(self) | ||
| } | ||
| } | ||
|
|
||
| #if (swift(>=5.7) && (os(iOS) || os(tvOS) || os(watchOS))) || (os(macOS) && swift(>=5.7.1)) |
There was a problem hiding this comment.
Starting with an easy conformance for Apple platforms. Could take a custom conformance for Linux/Wasm/Windows or wait for the new open source Foundation to close the gap.
stephencelis
commented
Jun 20, 2023
| func customDumpHelp<T, TargetStream>( | ||
| _ value: T, | ||
| to target: inout TargetStream, | ||
| func customDumpHelp<InnerT, InnerTargetStream>( |
There was a problem hiding this comment.
Unrelated Swift 6 error fix.
mbrandonw
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could tweak it a bit, but better than the default.