Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Html.Node adopts AsyncResponseEncodable #13

Merged
merged 2 commits into from
May 23, 2024

Conversation

adriansergheev
Copy link
Contributor

The addition allows for this to compile:

func routes(_ app: Application) throws {
	app.get { req async in
		layout(title: "Home", content: home)
	}
}

@adriansergheev
Copy link
Contributor Author

adriansergheev commented May 23, 2024

this seems to be a hard requirement now, it would not build otherwise!
@stephencelis @mbrandonw

Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@stephencelis stephencelis merged commit 16a83c4 into pointfreeco:main May 23, 2024
@stephencelis
Copy link
Member

Sorry for not merging much sooner 😄 We must have lost track of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants