Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Package.swift #34

Merged
merged 1 commit into from Oct 16, 2020
Merged

Update Package.swift #34

merged 1 commit into from Oct 16, 2020

Conversation

maximkrouk
Copy link
Contributor

@maximkrouk maximkrouk commented Oct 15, 2020

This PR fixes import for swift-tools-version 5.3

SwiftPM was unable to resolve package at https://github.com/pointfreeco/swift-nonempty

Maybe it's an SPM bug, but it saw neither "NonEmpty" nor "swift-nonempty" package names (now the second one works).

Also as far as I know (from some TCA issue and basic logic 馃檪) you try to follow Apple's package naming guidelines like "swift-log", "swift-algorithms" or "swift-composable-architecture", so "swift-notempty" should fit this style more.

Copy link
Member

@stephencelis stephencelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is def the move we wanted to make.

@stephencelis stephencelis merged commit b4f3776 into pointfreeco:main Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants