Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Carthage #107

Closed
wants to merge 4 commits into from
Closed

Conversation

mluisbrown
Copy link

This adds support for installing the Prelude frameworks using Carthage.

Basically:

  • remove the gitignore for .xcodeproj files
  • use the Prelude.xcodeproj file generated by make xcodeproj as a starting point, removing the Diff, SnapshotTesting and WKSnapshotConfigurationShim targets from the Run and Archive builds as they are incompatible with arm64 builds and aren't required when building as a dependency.
  • Add swift-tagged as a Carthage dependency (at version 0.2.0) using submodules (carthage checkout --use-submodules) and include the Tagged project into the Prelude workspace.
  • Delete the SPM created Tagged dependency from the Prelude project and use the framework built from the Tagged sub-project as the dependency for Prelude.

make xcodeproj will overwrite Prelude.xcodeproj so this doesn't affect building and testing using SPM.

@mluisbrown mluisbrown changed the title Adds support for Carthage Add support for Carthage Jul 2, 2018
@mbrandonw
Copy link
Member

@mluisbrown hey thanks for this and sorry for the radio silence! we're interested in doing this (and the same with some of our other packages), but we need a bit more time to figure out a sustainable way to do this. so far we've been having a bit of pain supporting Carthage.

Thanks again!

@mluisbrown
Copy link
Author

Thanks for letting me know @mbrandonw. What are the issues with Carthage that you are facing? At work we are looking to include Prelude into one of our frameworks and we would really need Carthage support for this.

@sloik
Copy link

sloik commented Aug 11, 2018

What about cocoapods? :)

@stephencelis
Copy link
Member

Hey @mluisbrown (and @sloik)! It's been awhile but we've been exploring this more recently and have an update here:
#113 (comment)

@stephencelis
Copy link
Member

And the world turns :) We've been slowly phasing out support for non-SPM tools, and Prelude's been in a bit of a "maintenance mode," so we're going to finally close this out. Thanks for coming along on the journey 😄

@stephencelis stephencelis mentioned this pull request Aug 16, 2021
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants