Don't require a test case subclass #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephencelis
commented
Nov 6, 2018
| tookSnapshot.fulfill() | ||
| } | ||
| let result = XCTWaiter.wait(for: [tookSnapshot], timeout: timeout) | ||
| switch result { |
There was a problem hiding this comment.
We need to manually fail based on the XCTWaiter result now.
stephencelis
commented
Nov 6, 2018
| tookSnapshot.fulfill() | ||
| } | ||
| #if os(Linux) | ||
| self.waitForExpectations(timeout: timeout) |
There was a problem hiding this comment.
I'm hoping this doesn't fail. Linux got the additional APIs in recent snapshots...
There was a problem hiding this comment.
Dang, merged less than a week ago: apple/swift-corelibs-xctest#228
Guess we can't merge and support Linux unless we lock Linux to a recent snapshot.
mbrandonw
approved these changes
Nov 7, 2018
|
Bless you both @stephencelis @mbrandonw, very excited to give this a test! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71.
Hoping that a serial queue makes things reliable.