Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix another crash around URLComponents/URLQueryItem #80

Merged
merged 3 commits into from Nov 30, 2017
Merged

Fix another crash around URLComponents/URLQueryItem #80

merged 3 commits into from Nov 30, 2017

Conversation

stephencelis
Copy link
Member

This one took awhile to track down! It appears that Linux Foundation has some issues with URLComponents and URLs that contain the same query key twice. Let's avoid URLComponents for now, and have a coupla action items:

  1. Change it so our GitHub response code string is optional (to avoid the double query, which is kinda undefined behavior).
  2. Get a failing test case over to Apple.

mbrandonw
mbrandonw approved these changes Nov 30, 2017
View reviewed changes
Copy link
Member

@mbrandonw mbrandonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

amazing!

the travis test that failed is the weird non-determinstic crypto one. I just restarted it, but you could merge either way!

@stephencelis stephencelis merged commit 0bd7749 into master Nov 30, 2017
@stephencelis stephencelis deleted the another-urlcomponents-crash-fix branch November 30, 2017 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbrandonw mbrandonw mbrandonw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@stephencelis @mbrandonw