Allow Binding<Case?> to write into nil
#54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently prevented
Binding.init?(unwrapping:case:)from changing the case, which makes sense because it's a failable initializer and we don't want ghost bindings to be able to write back into the system once the value goesnil. This includes a SwiftUI bug where text fields that are focused during dismissal can write into the binding, effectively un-dismissing the binding.I think we applied the same logic to
Binding.case, though, but I do not think that's what we want to do, and it actually caused a regression.Fixes #53.