Collect streaming request bodies #23
Conversation
Fixes #22. Request bodies of a certain size come in streaming and the properties return `nil`. We should check this and perform a check similar to what Vapor's routing tools do internally: https://github.com/vapor/vapor/blob/1d53c99b6ede0131bb02305f0d62fb2c6c830f3b/Sources/Vapor/Routing/RoutesBuilder%2BMethod.swift#L152
There was a problem hiding this comment.
This makes sense to me. It would be nice if Vapor Routing could support streaming the request body in addition to just collecting it. I guess that problem is that you wouldn't be able to parse the body without collecting the whole thing first. But this is great, and a nice bonus that you're using Vapor's configurable defaultMaxBodySize.
I tried this branch with my example project tests and with my real application, and both are working consistently with large requests after thousands of test repetitions. Thanks for finding a solution so quickly!
It'd definitely be nice to support streaming and incremental parsing in the future, but for now collecting everything and parsing all at once seems to be the way to go. Hopefully we'll be able to explore async parsing in the future! |
|
@dmzza Released 0.1.3 with the fix, thanks for reporting the bug! |
Fixes #22.
Request bodies of a certain size come in streaming and the properties return
nil. We should check this and perform a check similar to what Vapor's routing tools do internally:https://github.com/vapor/vapor/blob/1d53c99b6ede0131bb02305f0d62fb2c6c830f3b/Sources/Vapor/Routing/RoutesBuilder%2BMethod.swift#L152