Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

DFN-8-1EP_2x2mm_P0.5mm_EP0.75x1.2mm footprint for SPF5122Z. Note EP i… #578

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

chmorgan
Copy link
Contributor

…s extended in width per mfg layout recommendations

@codeclimate
Copy link

codeclimate bot commented Jul 19, 2020

Code Climate has analyzed commit f5b4ec2 and detected 0 issues on this pull request.

View more on Code Climate.

@chmorgan
Copy link
Contributor Author

@chschlue I'm stuck rebasing this on OSX as I'm case insensitive and git doesn't know how to handle a duplicate readme.md and Readme.md (#589). Once that is resolve I'll push updates and the fixed conflicts.

@myfreescalewebpage
Copy link
Contributor

@chmorgan I think "body_size_x" disappeared in the yaml file
I'm not sure of the footprint size either
Joel

@myfreescalewebpage
Copy link
Contributor

@chschlue what do you think ?

@chschlue
Copy link
Collaborator

body_size_x definitely disappeared.
Other than that, what specifically are you unsure about?

@myfreescalewebpage
Copy link
Contributor

Definitely:

Capture

0.6*1.2mm is the correct one

@chschlue
Copy link
Collaborator

Ah, yes.
This doesn't affect the output but it should in fact use the actual name of the generated footprint.

@myfreescalewebpage
Copy link
Contributor

Yes

@chmorgan
Copy link
Contributor Author

@chschlue @myfreescalewebpage I fixed the EP width incorrectly to match the pad. The suggested pad layout in https://www.qorvo.com/products/d/da001904 is 0.0295" or 0.749mm. Let me fix that and the missing body size, one min.

@chmorgan
Copy link
Contributor Author

If you'd like me to use the nominal EP that's probably ok too even if its slightly smaller than the recommendation. I was only following the recommendations because its an RF part and I don't understand if the fractions of a mm matter or not.

@chschlue
Copy link
Collaborator

Ah, yes. Go ahead.
Please remove the two superfluous lines below size_source and update the FP PR, then this should be good to go.

…s extended in width per mfg layout recommendations
… tolerance rather than minimum and maximum. Correct EP_size_x to match the recommended pad footprint in the datasheet.
@chmorgan
Copy link
Contributor Author

@chschlue @myfreescalewebpage pushed some fixes (and caught a merge issue that broke the footprint above this one, sorry about the force push but wanted to fix that in the first commit). How does this look now?

Copy link
Collaborator

@chschlue chschlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove the commented lines.

Comment on lines +282 to +283
EP_size_x:
nominal: 0.75
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please insert nominal package EP size (and tolerance) and add EP_size_x_overwrite: 0.75 to get the suggested footprint pad.

@chschlue chschlue self-assigned this Sep 25, 2020
@myfreescalewebpage
Copy link
Contributor

@chmorgan ping

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants