Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement auth token #615

Merged
merged 10 commits into from
Sep 1, 2022
Merged

Implement auth token #615

merged 10 commits into from
Sep 1, 2022

Conversation

Koochr
Copy link
Contributor

@Koochr Koochr commented Aug 30, 2022

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 30, 2022 •
edited

Unit Test Results

    1 files    18 suites   25s ⏱️
111 tests 102 ✔️ 9 💤 0 ❌
116 runs  107 ✔️ 9 💤 0 ❌

Results for commit f58898f.

♻️ This comment has been updated with latest results.

@Koochr Koochr changed the title Replace wouter with react-router-dom and implement setting token Implement auth token Aug 31, 2022
tankakatan
tankakatan reviewed Sep 1, 2022
View reviewed changes
Copy link
Collaborator

@tankakatan tankakatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the reason you replace wouter with react-router-dom? Also please turn off linter auto fixes, as long as it produces a lot of irrelevant changes that complicate reviews and increase the risk some crucial issues will remain unattended.

@Koochr
Copy link
Contributor Author

Koochr commented Sep 1, 2022

What is the reason you replace wouter with react-router-dom? Also please turn off linter auto fixes, as long as it produces a lot of irrelevant changes that complicate reviews and increase the risk some crucial issues will remain unattended.

wouter doesn't support query: molefrog/wouter#58

@amherag amherag merged commit 61d46a2 into develop Sep 1, 2022
@Koochr Koochr deleted the feature/auth-token branch September 2, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tankakatan tankakatan tankakatan left review comments

@amherag amherag amherag approved these changes

@sergevar sergevar Awaiting requested review from sergevar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Koochr @amherag @tankakatan