Add log2()<-, log10()<-, ilog2(), and ilog10() functions
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'exp2-exp10' of github.com:poissonconsulting/extras into log2-log10 # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Merge branch 'exp2-exp10' of github.com:poissonconsulting/extras into log2-log10 # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
joethorley
approved these changes
May 27, 2023
aylapear
requested changes
May 30, 2023
There was a problem hiding this comment.
- Review the parameter definitions in the params file to see if they are applicable for these functions.
- Split up the tests a bit further so each block is self contained to a single idea. So for example the edge cases block where it tests NULL, NA and Inf I would split those into their own test block as they are testing separate issues.
joethorley
approved these changes
May 30, 2023
aylapear
approved these changes
Jun 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow RHS and inverse evaluation of
2^xand10^x.These functions rely on the
exp2()andexp10()functions.