Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fwa_add_watershed_to_blk() failing #50

Closed
sebdalgarno opened this issue Oct 22, 2021 · 3 comments
Closed

fwa_add_watershed_to_blk() failing #50

sebdalgarno opened this issue Oct 22, 2021 · 3 comments

Comments

@sebdalgarno
Copy link
Member

just FYI - fwa_add_watershed_to_blk() currently failing after fresh install

streams <- fwa_find_stream_names("steep c") %>%
  fwa_add_blks_to_stream_name() %>%
  slice(1) %>%
  fwa_add_watershed_to_blk()
Error in if (!x$..fwa_exclude && wshed$refine_method == "KEEP") { : 
  missing value where TRUE/FALSE needed
In addition: Warning message:
Unknown or uninitialised column: `refine_method`. 
Backtrace:
    █
 1. ├─[ `%>%`(...) ]
 2. └─fwatlasbc::fwa_add_watershed_to_blk(.)
 3.   ├─[ dplyr::select(...) ]
 4.   ├─[ dplyr::arrange(...) ]
 5.   ├─[ dplyr::bind_rows(...) ] with 1 more call
 7.   └─base::lapply(...)
 8.     └─fwatlasbc:::FUN(X[[i]], ...)
 9.       └─fwatlasbc:::adjust_watershed(wshed, x, epsg)
@joethorley
Copy link
Member

Thanks doing it for me too - I'll fix shortly

joethorley added a commit that referenced this issue Oct 22, 2021
@joethorley
Copy link
Member

It seems to be to do with that old chestnut

Did the code work previously?

I've added a more informative error message.

@sebdalgarno
Copy link
Member Author

I'm not sure if the code worked previously but I just grabbed the code above from the README

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants