Allow to specify license key via plugin parameter #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 awesome idea @simoneb ! |
|
Thank you for the contribution. Could you update the documentation ? I will then merge the pull request. |
|
Check out the updated README, it carries all the documentation changes. On Mon, Oct 20, 2014 at 9:54 AM, Guillaume Charhon <notifications@github.com
|
poiuytrez
added a commit
that referenced
this pull request
Oct 20, 2014
Allow to specify license key via plugin parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #31 PGB currently does not allow customizing any steps of the build process, thus preventing the use of this plugin because there would be no way to customize or provide the Android license key.
This pull request changes the installation procedure of the plugin requiring to provide the license key upon installation (when installing using the cordova cli) and upon configuration in the config.xml file (when configuring for PGB). The changes are minimal although they lead to a different installation procedure which is not compatible anymore with the previous one, based on copying the res xml file to the platforms folder (I tried to figure out whether it was possible to keep a backwards compatible way to install the plugin but that doesn't seem to be possible).