Skip to content

Commit

Permalink
Merge pull request #1008 from cobicarmel/release/1.0.1
Browse files Browse the repository at this point in the history
Fixed Multiple Events Binding
  • Loading branch information
KingYes committed Dec 7, 2016
2 parents c3c428a + d8f4aba commit 675b6fe
Show file tree
Hide file tree
Showing 4 changed files with 35 additions and 3 deletions.
16 changes: 16 additions & 0 deletions assets/dev/js/frontend/elements-handler.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,22 @@ ElementsHandler = function( $ ) {

elementorFrontend.hooks.doAction( 'frontend/element_ready/' + elementType, $scope, $ );
};

this.addExternalListener = function( $scope, event, callback, externalElement ) {
var $externalElement = $( externalElement || elementorFrontend.getScopeWindow() );

if ( ! elementorFrontend.isEditMode() ) {
$externalElement.on( event, callback );

return;
}

var eventNS = event + '.' + $scope.attr( 'id' );

$externalElement
.off( eventNS )
.on( eventNS, callback );
};
};

module.exports = ElementsHandler;
2 changes: 1 addition & 1 deletion assets/dev/js/frontend/handlers/section.js
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,7 @@ var StretchedSection = function( $section, $ ) {
};

var bindEvents = function() {
elements.$scopeWindow.on( 'resize', stretchSection );
elementorFrontend.elementsHandler.addExternalListener( $section, 'resize', stretchSection );
};

var init = function() {
Expand Down
18 changes: 17 additions & 1 deletion assets/js/frontend.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 675b6fe

Please sign in to comment.