Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After upgrading to version 1.0.0 stopped working counter #1001

Closed
oto-xara opened this issue Dec 6, 2016 · 13 comments
Closed

After upgrading to version 1.0.0 stopped working counter #1001

oto-xara opened this issue Dec 6, 2016 · 13 comments
Labels
bug Indicates a bug with one or multiple components.

Comments

@oto-xara
Copy link

oto-xara commented Dec 6, 2016

http://prntscr.com/dg384h

No animation

@arielk
Copy link
Member

arielk commented Dec 6, 2016

Hi

Please deactivate all of your plugins. If this solves the problem, gradually activate your plugins one by one, until you spot the problematic plugin.

If you have a caching plugin, make sure you deactivate it, or even better – purge the cache.

thanks

@iamntz
Copy link
Contributor

iamntz commented Dec 6, 2016

Ahem.... #993

@oto-xara
Copy link
Author

oto-xara commented Dec 6, 2016

@arielk I tried, it didn't help

@iamntz I did fix which are described in #993

I made changes to the file:
wp-content/plugins/elementor/assets/js/frontend.js

it did not help, counter still not working

@luisvivasb
Copy link

luisvivasb commented Dec 6, 2016

Hi @oto-xara, if you make change in .js file you have to activate the "SCRIPT_DEBUG" because Elemenor use frontend.min.js

Add this on plugins/elementor/elementor.php
define('SCRIPT_DEBUG', true);

@oto-xara
Copy link
Author

oto-xara commented Dec 7, 2016

@luisvivasb, it's still not working, what am I doing wrong?

http://prnt.sc/dgdhvx

@iamntz
Copy link
Contributor

iamntz commented Dec 7, 2016

Can you open console and check if you see any errors there?

@oto-xara
Copy link
Author

oto-xara commented Dec 7, 2016

@iamntz, yes when I load the page in elementory

http://prntscr.com/dgeg9g

http://prntscr.com/dgehyn

@iamntz
Copy link
Contributor

iamntz commented Dec 7, 2016

You need to add SCRIPT_DEBUG constant into your wp-config.php file.

@oto-xara
Copy link
Author

oto-xara commented Dec 7, 2016

Thank you! it helped! uhh...not easy to fix it)

this code needs to stay in there? or it can be removed?

the following updates will not break this code?

@iamntz
Copy link
Contributor

iamntz commented Dec 7, 2016

Well, it will break only if @cobicarmel will agree that there is a problem there. Otherwise... :)

@oto-xara
Copy link
Author

oto-xara commented Dec 7, 2016

it's definitely a bug. I hope it will be fixed

@agusmu
Copy link

agusmu commented Dec 7, 2016

I tried to test it on my Elementor v1.0.0

on live editor, counter widget works...

but on frontend, counter widget doesn't work...

@arielk arielk added the bug Indicates a bug with one or multiple components. label Dec 7, 2016
@KingYes
Copy link
Member

KingYes commented Dec 7, 2016

Thanks!
We fixed this by this PR: #1007

@KingYes KingYes closed this as completed Dec 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates a bug with one or multiple components.
Projects
None yet
Development

No branches or pull requests

6 participants