Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Carousel "slides to show" on tablet #372

Closed
daviedR opened this issue Aug 4, 2016 · 3 comments
Closed

Image Carousel "slides to show" on tablet #372

daviedR opened this issue Aug 4, 2016 · 3 comments
Labels
bug Indicates a bug with one or multiple components. type/responsive Indicates when a topic is related to Responsive Design, for tablet, mobile, and other screens.

Comments

@daviedR
Copy link
Contributor

daviedR commented Aug 4, 2016

Hi guys, I just found another issue.

If you have an image carousel with slidesToShow: 1, and see it on live page (not in Elementor Editor mode), the slider will resize to 2 slides when on 480-766px viewport:

When on larger than 766px viewport:
image

When on 480 - 766px viewport:
image

If you look at frontend.js, you make default configurations like this:

        var defaultOptions = {
                responsive: [
                    {
                        breakpoint: 767,
                        settings: {
                            slidesToShow: 2,
                            slidesToScroll: 2
                        }
                    },
                    {
                        breakpoint: 480,
                        settings: {
                            slidesToShow: 1,
                            slidesToScroll: 1
                        }
                    }
                ]
            },

            slickOptions = $.extend( {}, defaultOptions, $carousel.data( 'slider_options' ) );

It seems there is no way to override this default configurations when users choose slidesToShow: 1 on the Elementor editor.

Another question:
Could you define the table breakpoint as 768 instead of 767? If you define 767 the layout would change when reached 766px. It's 1 pixel difference, but seems important.

Thanks!

@Nat-Faeeria
Copy link

#227 #286

@arielk arielk added type/responsive Indicates when a topic is related to Responsive Design, for tablet, mobile, and other screens. bug Indicates a bug with one or multiple components. labels Aug 5, 2016
@arielk
Copy link
Member

arielk commented Aug 5, 2016

We're going to take care of everything related to responsive the following versions, thanks for your report

@arielk arielk modified the milestone: 0.8 Aug 16, 2016
@arielk
Copy link
Member

arielk commented Aug 17, 2016

Fixed 2677b9d

@arielk arielk closed this as completed Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates a bug with one or multiple components. type/responsive Indicates when a topic is related to Responsive Design, for tablet, mobile, and other screens.
Projects
None yet
Development

No branches or pull requests

3 participants