Improve SVG compression #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the unneeded `version` attribute and reran SVGs through the latest SVGO.
XhmikosR
commented
Sep 22, 2020
| ); | ||
| } | ||
|
|
||
| if ( isset( $icons[ $icon ] ) ) { | ||
| return sprintf( '<svg version="1.1" xmlns="http://www.w3.org/2000/svg" width="1em" viewBox="0 0 448 448">%s</svg>', $icons[ $icon ] ); | ||
| return sprintf( '<svg xmlns="http://www.w3.org/2000/svg" width="1em" viewBox="0 0 448 448">%s</svg>', $icons[ $icon ] ); |
There was a problem hiding this comment.
Arguably, this should include a height attribute too. IE for example is known not to work properly without dimensions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the unneeded
versionattribute and reran SVGs through the latest SVGO.Do note that this also includes #45, so CC me if a rebase is needed. Also, better compare without whitespace.