Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix ValueError when PvP levels are unknown #870

Merged
merged 1 commit into from
Feb 13, 2023
Merged

fix ValueError when PvP levels are unknown #870

merged 1 commit into from
Feb 13, 2023

Conversation

sprintnudel
Copy link
Contributor

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (would cause existing functionality to change)

Motivation and Context

The PvP optimization patch had an oversight, when dealing with non-encountered mons.

How Has This Been Tested?

Asked the reporter to test, will update with results.

Wiki Update

  • This change requires an update to the Wiki.
  • This change does not require an update to the Wiki.

@sprintnudel
Copy link
Contributor Author

Reporter confirmed fix on Discord.

@sprintnudel sprintnudel mentioned this pull request Feb 6, 2023
Open
5 tasks
@LegitDongo LegitDongo merged commit ef184cd into pokealarm:dev Feb 13, 2023
@LegitDongo LegitDongo added priority: medium type: bug Unexpected or incorrect behavior. labels Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LegitDongo LegitDongo LegitDongo approved these changes

Assignees
No one assigned
Labels
priority: medium type: bug Unexpected or incorrect behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sprintnudel @LegitDongo