Refactored project to be re-usable as a Xcode sub-project #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Removed Mac test app
…ke up project in several smaller targets, in case s# support is not required
Updated deployment target to 4.3 to avoid an issue where Xcode 4.5+ use iOS 6.0 as "default" target. This cause problems when the project is included as a sub-project in projects targetting iOS <6.0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASIHTTPRequest is an amazing piece of software. Unfortunately the packaging is more of a "Sample application" than a re-usable component.
I have refactored the project into several Targets with the intention that clients can add the project as an Xcode sub-project and link with the resulting products.
The Sample apps and unit tests targets links against the static libraries, they do NOT touch the source files, in order to verify and showcase both functionality and how the build system works.
I have not created targets for Mac OS X. These should propbably be created as proper Framework targets.
I have written a longer blog-post about Xcode sub-projects, and git sub-modules, describing the rationale for these changes here: http://blog.jayway.com/2011/05/16/the-state-of-ios-open-source-and-what-to-do-about-it/