Fix memory leak in IOS7 #382
Conversation
|
This looks like a relatively big change - is it possible to get a bit more info about why the old code was wrong, and how the new code solves it? If anyone else tests the code in here, it would be great to have some comments to say if it works or not etc. (I don't have any live projects that still use ASIHTTPRequest.) |
|
I have tested this modification,it works out,solved the iOS 7 memory leak issue.Thanks for heroims' contribution! |
|
Great, thanks @LuoDengfeng Has anyone been able to check if the metrics still work? (I think that's the bandwidth recording code etc.) I'd be interested to know if anyone has checked it on Mac OS X or not too. |
|
This is quite critical. Merge to Master @pokeb when you check it out :D! |
|
@pokeb can you fix the leak problem？ |
|
pokeb isn't active on the project anymore. I'm happy to look at merging this, but my time is very limited, so it's really useful if other people can help - the work that stills needs to be done is to resolve the conflicts, confirm if metrics still work and check this on Mac OS X. |
|
@heroims 我感觉这个修复，没有看出leak的真正的原因或者切入点在哪里。 只是覆盖了CFNetwork底层可能调用到的NSInputStream的一些没有公开的接口，万一以后苹果再更新它的实现，是不是又会出问题！ |
|
@kejinlu 那时候我再做新调整 |
No description provided.