Implement SPRITE_PLUS_MASK functionality #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented in pure C/C++ code so it will work on both the simulator and the Pokitto itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented in pure C/C++ code so it will work on both the simulator and the Pokitto itself.
I have confirmed that this works on the Arduboy, so logically it should work on the Pokitto.
However it would be best if someone else tests it before merging to be sure.
The sketch I used to test the code was a variation of the now semi-famous 'questor' sketch which I find quite handy for specifically testing
Sprites::drawPlusMask. If no other sketch is readily available to test the code, I recommend using this one because of its historical significance and use of large animated sprites (which make it easier to spot cases where drawing isn't working correctly).