-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create XRayInstrument #16
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # Package.swift
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for creating this PR, looks great already 👍
I've added some comments inline.
@slashmo thank you for the comments and snippets, I will copy that and commit. feel welcome to push changes, just until it works more or less and tests pass (those I created fail miserably lol) let's consider The refactoring changes I noted in my head yesterday:
|
well, the tests defined yesterday pass now - so its a small progress ;-) |
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
+ Coverage 77.11% 77.76% +0.64%
==========================================
Files 29 31 +2
Lines 1219 1277 +58
==========================================
+ Hits 940 993 +53
- Misses 279 284 +5
Continue to review full report at Codecov.
|
# Conflicts: # Examples/Package.swift # Package.swift
I deployed a "hello world" lambda a few weeks ago when testing
result from note that currently events are recorded as both subsegments and metadata: |
Wow, that's awesome! 🎉 |
Ah thanks a lot, that explains how metadata is presented. I guess yeah events in there sound like an okey way to at least show them to users somehow 👍 |
# Conflicts: # Examples/Package.swift # Package.swift
# Conflicts: # Examples/Package.swift
No description provided.