[Persistence] Update KVStore to use Badger wrapper functions

[h5law]

Description

This PR introduces unit tests to cover the KVStore's functionality as well as updating the KVStore logic to use the Badger wrapper functions update, view, etc.

This fixes the issues around deleting keys from the KVStore.

Issue

Fixes N/A

Type of change

Please mark the relevant option(s):

• New feature, functionality or library
• Bug fix
• Code health or cleanup
• Major breaking change
• Documentation
• Other

List of changes

• Update KVStore to use badger's wrapper functions
• Add KVStore unit tests

Testing

• make develop_test; if any code changes were made
• make test_e2e on k8s LocalNet; if any code changes were made
• e2e-devnet-test passes tests on DevNet; if any code was changed
• Docker Compose LocalNet; if any major functionality was changed or introduced
• k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
• I have tested my changes using the available tooling
• I have updated the corresponding CHANGELOG

If Applicable Checklist

• I have updated the corresponding README(s); local and/or global
• I have added tests that prove my fix is effective or that my feature works
• I have added, or updated, mermaid.js diagrams in the corresponding README(s)
• I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

[codecov]

Codecov Report

Patch coverage: 77.08% and project coverage change: +0.33 🎉

Comparison is base (2d4f789) 31.52% compared to head (9198c7a) 31.86%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #838      +/-   ##
==========================================
+ Coverage   31.52%   31.86%   +0.33%     
==========================================
  Files         107      108       +1     
  Lines        9034     9126      +92     
==========================================
+ Hits         2848     2908      +60     
- Misses       5846     5874      +28     
- Partials      340      344       +4     

Impacted Files	Coverage Δ
persistence/kvstore/kvstore.go	65.21% <77.08%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Olshansk]

PTAL at couple tiny comments and feel free to merge after

[Olshansk]

hex.Dump(invalidKey[:1<<10])),

🆒

[h5law]

NOTE @Olshansk, @dylanlott is currently working on savepoints/rollbacks that touches the same code and this PR will probably only be used as a reference as he is changing the logic their. The new wrapper functions fix the bug with Delete() but need to be integrated with savepoints. Will wait on merging this until @dylanlott gives an update

[Olshansk]

This PR is already complete and ready to be merged in, while savepoints & rollbacks PR is 1+ weeks away.

IMO we should merge this in and iterate on top of it. However, I will defer to @dylanlott to decide.

[dylanlott]

This PR is already complete and ready to be merged in, while savepoints & rollbacks PR is 1+ weeks away.

IMO we should merge this in and iterate on top of it. However, I will defer to @dylanlott to decide.

I agree with merging this and addressing the logic changes necessary for savepoints later. It shouldn't hold this up.