Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IBC] chore: Rename FlushAllEntries => FlushCachesToStore #934

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

h5law
Copy link
Contributor

@h5law h5law commented Jul 24, 2023

Description

Summary generated by Reviewpad on 24 Jul 23 15:58 UTC

This pull request renames the FlushAllEntries function to FlushCachesToStore in multiple files. The function is responsible for flushing the cache entries for all stores in the bulkStoreCache struct. The renaming is consistent across the affected files, including ibc_handle_event_test.go, module.go, bulk_store_cache.go, provable_store.go, provable_store_test.go, mock.go, and ibc_store_module.go. The patch also includes some code formatting changes.

Issue

Fixes https://github.com/pokt-network/pocket/pull/868/files#r1262167821

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

  • Rename FlushAllEntries to FlushCachesToStore
  • Rename FlushEntries to FlushCache

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@h5law h5law added code health Nice to have code improvement e2e-devnet-test Runs E2E tests on devnet ibc IBC specific changes labels Jul 24, 2023
@h5law h5law requested review from Olshansk and dylanlott July 24, 2023 15:58
@h5law h5law self-assigned this Jul 24, 2023
@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Jul 24, 2023
@h5law h5law merged commit 98bac7c into main Jul 24, 2023
15 checks passed
@h5law h5law deleted the ibc/rename_flush_entries branch July 24, 2023 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Nice to have code improvement e2e-devnet-test Runs E2E tests on devnet ibc IBC specific changes small Pull request is small waiting-for-review
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants