-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AppGateServer] Refactor the AppGate server to use the new shannon-sdk implementation #636
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preemptively approving 🔥 🚀 - only 1 question this time. 😅
// Filter out the supplier endpoints that match the requested serviceId. | ||
validSupplierEndpoints := make([]*sdktypes.SingleSupplierEndpoint, 0, len(supplierEndpoints)) | ||
) (supplierEndpoint shannonsdk.Endpoint, err error) { | ||
endpoints, err := sessionEndpoints.AllEndpoints() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why use #AllEndpoints()
here instead of adding some filter function(s) - maybe #PUC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// AppGateServer uses the custom getRelayerUrl instead of leveraging the SDK's
// filter to select the next endpoint to use.
// This is because it needs to maintain the state of the last selected endpoint
// and have a view on the original request URL to determine the next endpoint.
// This behavior is specific to the AppGateServer and needed by clients that
// need to instrument the endpoint selection strategy, such as the Load testing tool.
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 636) |
Summary
Import and use the new
shannon-sdk
implementation to implement theAppGateServer
.Type of change
Select one or more:
Testing
Documentation changes (only if making doc changes)
make docusaurus_start
; only needed if you make doc changesLocal Testing (only if making code changes)
make go_develop_and_test
make test_e2e
PR Testing (only if making code changes)
devnet-test-e2e
label to the PR.make trigger_ci
if you want to re-trigger tests without any code changesSanity Checklist