Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Integration fixes after the v0.11.0 release #49

Merged
merged 7 commits into from
Jun 14, 2024
Merged

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented Jun 14, 2024

Summary

  • Exposing NewTrieSpec publically
  • Adding back Sum function to the MerkleRoot type
  • Adding a new Count function to the MerkleRoot type
  • Adding back PathHasherSize

Human Summary

AI Summary

reviewpad:summary

Issue

Fixing a few integration issues with poktroll after this release: https://github.com/pokt-network/smt/releases/tag/v0.11.0

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make test_all
  • Run all/relevant benchmarks (if optimising): make benchmark_{all | suite name}

Required Checklist

If Applicable Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have updated any relevant README(s)/documentation and left TODOs throughout the codebase
  • Add or update any relevant or supporting mermaid diagrams

@Olshansk Olshansk added the bug Something isn't working label Jun 14, 2024
@Olshansk Olshansk requested a review from red-0ne June 14, 2024 01:21
@Olshansk Olshansk self-assigned this Jun 14, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 16.66667% with 20 lines in your changes missing coverage. Please review.

Project coverage is 81.99%. Comparing base (e3dbbbd) to head (650471b).
Report is 12 commits behind head on main.

Files Patch % Lines
root.go 0.00% 16 Missing ⚠️
trie_spec.go 33.33% 3 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #49      +/-   ##
==========================================
+ Coverage   81.31%   81.99%   +0.68%     
==========================================
  Files           9       15       +6     
  Lines        1493     1711     +218     
==========================================
+ Hits         1214     1403     +189     
- Misses        215      244      +29     
  Partials       64       64              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@red-0ne red-0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of NITs but gtg.

root.go Outdated Show resolved Hide resolved
root.go Outdated Show resolved Hide resolved
Olshansk and others added 3 commits June 13, 2024 20:12
Co-authored-by: Redouane Lakrache <r3d0ne@gmail.com>
Signed-off-by: Daniel Olshansky <olshansky.daniel@gmail.com>
Co-authored-by: Redouane Lakrache <r3d0ne@gmail.com>
Signed-off-by: Daniel Olshansky <olshansky.daniel@gmail.com>
@Olshansk Olshansk merged commit ea585c6 into main Jun 14, 2024
2 checks passed
@Olshansk Olshansk deleted the minor_fixes branch June 14, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants