Skip to content

Commit

Permalink
Upgrade maturin to 0.13.0 (#4086)
Browse files Browse the repository at this point in the history
  • Loading branch information
messense committed Jul 20, 2022
1 parent 05aac02 commit 0910ec3
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
source venv/bin/activate
pip install -r py-polars/build.requirements.txt
cd py-polars
rustup override set nightly-2022-06-22 && RUSTFLAGS="-C embed-bitcode" maturin develop --rustc-extra-args="-C codegen-units=8 -C lto=thin -C target-cpu=native" --release
rustup override set nightly-2022-06-22 && RUSTFLAGS="-C embed-bitcode" maturin develop --release -- -C codegen-units=8 -C lto=thin -C target-cpu=native
cd tests/db-benchmark
Rscript -e 'install.packages("data.table", repos="https://Rdatatable.github.io/data.table")'
Rscript groupby-datagen.R 1e7 1e2 5 0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/create-py-mac-universal2-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
env:
MATURIN_PASSWORD: ${{ secrets.PYPI_PASS }}
with:
maturin-version: 0.12.1
maturin-version: '0.13.0'
command: publish
args: -m py-polars/Cargo.toml --target aarch64-apple-darwin --no-sdist -o wheels -i python -u ritchie46
# uncomment to build a universal2 wheel
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/create-py-release-manylinux.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
steps:
- uses: actions/checkout@v3
- name: publish x86_64
uses: docker://konstin2/maturin:latest
uses: docker://ghcr.io/pyo3/maturin:latest
env:
MATURIN_PASSWORD: ${{ secrets.PYPI_PASS }}
with:
Expand All @@ -28,6 +28,6 @@ jobs:
# don't use `2_17` it does not work: https://github.com/pola-rs/polars/runs/6107328960
manylinux: '2_24'
target: aarch64-unknown-linux-gnu
maturin-version: 0.12.1
maturin-version: '0.13.0'
command: publish
args: -m py-polars/Cargo.toml --no-sdist -o wheels -i python -u ritchie46
2 changes: 1 addition & 1 deletion .github/workflows/create-py-release-windows-macos.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ jobs:
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install maturin==0.12.1
pip install maturin==0.13.0
- name: Publish wheel
shell: bash
env:
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -153,11 +153,11 @@ This can be done by going through the following steps in sequence:
3. Choose any of:
* Fastest binary, very long compile times:
```bash
$ cd py-polars && maturin develop --rustc-extra-args="-C target-cpu=native" --release
$ cd py-polars && maturin develop --release -- -C target-cpu=native
```
* Fast binary, Shorter compile times:
```bash
$ cd py-polars && maturin develop --rustc-extra-args="-C codegen-units=16 -C lto=thin -C target-cpu=native" --release
$ cd py-polars && maturin develop --release -- -C codegen-units=16 -C lto=thin -C target-cpu=native
```

Note that the Rust crate implementing the Python bindings is called `py-polars` to distinguish from the wrapped
Expand Down
2 changes: 1 addition & 1 deletion examples/python_rust_compiled_function/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[build-system]
requires = ["maturin>=0.12,<0.13"]
requires = ["maturin>=0.13,<0.14"]
build-backend = "maturin"

[project]
Expand Down
2 changes: 1 addition & 1 deletion py-polars/build.requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ pytz
types-pytz

# Tooling
maturin==0.12.19
maturin==0.13.0
pytest==7.1.2
pytest-cov[toml]==3.0.0
hypothesis==6.49.1
Expand Down
2 changes: 1 addition & 1 deletion py-polars/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[build-system]
requires = ["maturin>=0.12,<0.13"]
requires = ["maturin>=0.13,<0.14"]
build-backend = "maturin"

[project]
Expand Down

0 comments on commit 0910ec3

Please sign in to comment.