Skip to content

Commit

Permalink
perf(rust): lower contention in out of core filter (#5311)
Browse files Browse the repository at this point in the history
  • Loading branch information
ritchie46 committed Oct 24, 2022
1 parent a3e2eb6 commit 0940b28
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,9 @@ impl Operator for FilterOperator {
format!("Filter predicate must be of type Boolean, got: {:?}", e).into(),
)
})?;
// TODO! filter sequentially?
let df = chunk.data.filter(mask)?;
// the filter is sequential as they are already executed on different threads
// we don't want to increase contention and data copies
let df = chunk.data._filter_seq(mask)?;

Ok(OperatorResult::Finished(chunk.with_data(df)))
}
Expand Down

0 comments on commit 0940b28

Please sign in to comment.