update rustc (#2978)

pola-rs · Mar 25, 2022 · 12d8c73 · 12d8c73
1 parent f5851b5
commit 12d8c73
Show file tree

Hide file tree

Showing 14 changed files with 28 additions and 19 deletions.
diff --git a/.github/deploy_manylinux.sh b/.github/deploy_manylinux.sh
@@ -7,7 +7,7 @@ ls -la
 rm py-polars/README.md
 cp README.md py-polars/README.md
 cd py-polars
-rustup override set nightly-2022-03-16
+rustup override set nightly-2022-03-23
 export RUSTFLAGS='-C target-feature=+fxsr,+sse,+sse2,+sse3,+ssse3,+sse4.1+sse4.2,+popcnt,+avx,+fma'
 maturin publish \
   --skip-existing \

diff --git a/.github/workflows/benchmark.yaml b/.github/workflows/benchmark.yaml
@@ -12,7 +12,7 @@ jobs:
       - name: Install latest Rust nightly
         uses: actions-rs/toolchain@v1
         with:
-          toolchain: nightly-2022-03-16
+          toolchain: nightly-2022-03-23
           override: true
           components: rustfmt, clippy
       - name: Set up Python
@@ -32,7 +32,7 @@ jobs:
           source venv/bin/activate
           pip install -r py-polars/build.requirements.txt
           cd py-polars
-          rustup override set nightly-2022-03-16 && RUSTFLAGS="-C embed-bitcode" maturin develop --rustc-extra-args="-C codegen-units=8 -C lto=thin -C target-cpu=native" --release
+          rustup override set nightly-2022-03-23 && RUSTFLAGS="-C embed-bitcode" maturin develop --rustc-extra-args="-C codegen-units=8 -C lto=thin -C target-cpu=native" --release
           cd tests/db-benchmark
           Rscript -e 'install.packages("data.table", repos="https://Rdatatable.github.io/data.table")'
           Rscript groupby-datagen.R 1e7 1e2 5 0

diff --git a/.github/workflows/build-test.yaml b/.github/workflows/build-test.yaml
@@ -25,7 +25,7 @@ jobs:
       - name: Install Rust nightly
         uses: actions-rs/toolchain@v1
         with:
-          toolchain: nightly-2022-03-16
+          toolchain: nightly-2022-03-23
           override: true
       - uses: Swatinem/rust-cache@v1
       - name: Install dependencies
@@ -43,7 +43,7 @@ jobs:
       - name: Install latest Rust nightly
         uses: actions-rs/toolchain@v1
         with:
-          toolchain: nightly-2022-03-16
+          toolchain: nightly-2022-03-23
           override: true
           components: rustfmt, clippy, miri
       - name: Cache Cargo

diff --git a/.github/workflows/create-py-mac-universal2-release.yaml b/.github/workflows/create-py-mac-universal2-release.yaml
@@ -19,7 +19,7 @@ jobs:
       - name: Install latest Rust nightly
         uses: actions-rs/toolchain@v1
         with:
-          toolchain: nightly-2022-03-16
+          toolchain: nightly-2022-03-23
           override: true
           components: rustfmt, clippy
       - name: Setup universal2 targets for Rust
@@ -35,7 +35,7 @@ jobs:
           rm py-polars/README.md
           cp README.md py-polars/README.md
           cd py-polars
-          rustup override set nightly-2022-03-16
+          rustup override set nightly-2022-03-23
       - name: maturin publish
         uses: messense/maturin-action@v1
         env:

diff --git a/.github/workflows/create-py-release-manylinux.yaml b/.github/workflows/create-py-release-manylinux.yaml
@@ -24,7 +24,7 @@ jobs:
         env:
           MATURIN_PASSWORD: ${{ secrets.PYPI_PASS }}
         with:
-          rust-toolchain: nightly-2022-03-16
+          rust-toolchain: nightly-2022-03-23
           manylinux: '2_24'
           target: aarch64-unknown-linux-gnu
           maturin-version: 0.12.1

diff --git a/.github/workflows/create-py-release-windows-macos.yaml b/.github/workflows/create-py-release-windows-macos.yaml
@@ -18,7 +18,7 @@ jobs:
         - name: Install latest Rust nightly
           uses: actions-rs/toolchain@v1
           with:
-            toolchain: nightly-2022-03-16
+            toolchain: nightly-2022-03-23
             override: true
             components: rustfmt, clippy
         - name: Set up Python
@@ -37,7 +37,7 @@ jobs:
             rm py-polars/README.md
             cp README.md py-polars/README.md
             cd py-polars
-            rustup override set nightly-2022-03-16
+            rustup override set nightly-2022-03-23
             export RUSTFLAGS='-C target-feature=+fxsr,+sse,+sse2,+sse3'
             maturin publish \
             --no-sdist \

diff --git a/.github/workflows/docs.yaml b/.github/workflows/docs.yaml
@@ -14,7 +14,7 @@ jobs:
       - name: Install latest Rust nightly
         uses: actions-rs/toolchain@v1
         with:
-          toolchain: nightly-2022-03-16
+          toolchain: nightly-2022-03-23
           override: true
           components: rustfmt, clippy
       - name: Set up Node

diff --git a/.github/workflows/test-js.yaml b/.github/workflows/test-js.yaml
@@ -24,7 +24,7 @@ jobs:
       - name: Install latest Rust nightly
         uses: actions-rs/toolchain@v1
         with:
-          toolchain: nightly-2022-03-16
+          toolchain: nightly-2022-03-23
           override: true
           components: rustfmt, clippy
       - run: yarn --version

diff --git a/.github/workflows/test-python.yaml b/.github/workflows/test-python.yaml
@@ -17,7 +17,7 @@ jobs:
       - name: Install latest Rust nightly
         uses: actions-rs/toolchain@v1
         with:
-          toolchain: nightly-2022-03-16
+          toolchain: nightly-2022-03-23
           override: true
           components: rustfmt, clippy
       - name: Set up Python
@@ -30,7 +30,7 @@ jobs:
           pip install -r py-polars/build.requirements.txt
       - name: Run formatting checks
         run: |
-          cd py-polars && black --check . && blackdoc --check . && isort --check . && rustup override set nightly-2022-03-16 && cargo fmt --all -- --check && cd ..
+          cd py-polars && black --check . && blackdoc --check . && isort --check . && rustup override set nightly-2022-03-23 && cargo fmt --all -- --check && cd ..
       - name: Run linting
         run: |
           cd py-polars && flake8 && cd ..
@@ -40,7 +40,7 @@ jobs:
       - name: Run tests
         run: |
           export RUSTFLAGS="-C debuginfo=0"
-          cd py-polars && rustup override set nightly-2022-03-16 && make venv && make test-with-cov
+          cd py-polars && rustup override set nightly-2022-03-23 && make venv && make test-with-cov
           cargo clippy
       - name: Check doc examples
         run: |

diff --git a/.github/workflows/test-windows-python.yaml b/.github/workflows/test-windows-python.yaml
@@ -13,7 +13,7 @@ jobs:
       - name: Install latest Rust nightly
         uses: actions-rs/toolchain@v1
         with:
-          toolchain: nightly-2022-03-16
+          toolchain: nightly-2022-03-23
           override: true
           components: rustfmt, clippy
       - name: Set up Python
@@ -28,7 +28,7 @@ jobs:
         shell: bash
         run: |
           export RUSTFLAGS="-C debuginfo=0"
-          cd py-polars && rustup override set nightly-2022-03-16 && make build-and-test-no-venv
+          cd py-polars && rustup override set nightly-2022-03-23 && make build-and-test-no-venv
           cargo clippy
       # test if we can import polars without any requirements
       - name: Import polars

diff --git a/.github/workflows/test-windows.yaml b/.github/workflows/test-windows.yaml
@@ -12,7 +12,7 @@ jobs:
       - name: Install latest Rust nightly
         uses: actions-rs/toolchain@v1
         with:
-          toolchain: nightly-2022-03-16
+          toolchain: nightly-2022-03-23
           override: true
       - name: Run tests
         run: |

diff --git a/nodejs-polars/rust-toolchain b/nodejs-polars/rust-toolchain
@@ -1 +1 @@
-nightly-2022-03-16
+nightly-2022-03-23
diff --git a/polars/polars-core/src/frame/groupby/pivot.rs b/polars/polars-core/src/frame/groupby/pivot.rs
@@ -23,6 +23,11 @@ pub enum PivotAgg {
 }
 
 impl DataFrame {
+    /// Do a pivot operation based on the group key, a pivot column and an aggregation function on the values column.
+    ///
+    /// # Note
+    /// Polars'/arrow memory is not ideal for transposing operations like pivots.
+    /// If you have a relatively large table, consider using a groupby over a pivot.
     pub fn pivot<I0, S0, I1, S1, I2, S2>(
         &self,
         values: I0,

diff --git a/py-polars/polars/internals/frame.py b/py-polars/polars/internals/frame.py
@@ -5585,6 +5585,10 @@ def pivot(
         """
         Do a pivot operation based on the group key, a pivot column and an aggregation function on the values column.
 
+        .. note::
+            Polars'/arrow memory is not ideal for transposing operations like pivots. If you have a relatively large
+            table, consider using a groupby over a pivot.
+
         Parameters
         ----------
         pivot_column