Skip to content

Commit

Permalink
more node updates (#3562)
Browse files Browse the repository at this point in the history
  • Loading branch information
universalmind303 committed Jun 2, 2022
1 parent f1df2cb commit 322f1ed
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions nodejs-polars/src/conversion.rs
Original file line number Diff line number Diff line change
Expand Up @@ -340,9 +340,9 @@ impl FromNapiValue for Wrap<ParquetCompression> {
let compression = String::from_napi_value(env, napi_val)?;
let compression = match compression.as_ref() {
"snappy" => ParquetCompression::Snappy,
"gzip" => ParquetCompression::Gzip,
"gzip" => ParquetCompression::Gzip(None),
"lzo" => ParquetCompression::Lzo,
"brotli" => ParquetCompression::Brotli,
"brotli" => ParquetCompression::Brotli(None),
"lz4" => ParquetCompression::Lz4Raw,
"zstd" => ParquetCompression::Zstd(None),
_ => ParquetCompression::Uncompressed,
Expand Down Expand Up @@ -415,8 +415,8 @@ impl FromNapiValue for Wrap<FillNullStrategy> {
unsafe fn from_napi_value(env: sys::napi_env, napi_val: sys::napi_value) -> JsResult<Self> {
let method = String::from_napi_value(env, napi_val)?;
let method = match method.as_ref() {
"backward" => FillNullStrategy::Backward,
"forward" => FillNullStrategy::Forward,
"backward" => FillNullStrategy::Backward(None),
"forward" => FillNullStrategy::Forward(None),
"min" => FillNullStrategy::Min,
"max" => FillNullStrategy::Max,
"mean" => FillNullStrategy::Mean,
Expand Down
4 changes: 2 additions & 2 deletions nodejs-polars/src/lazy/dsl.rs
Original file line number Diff line number Diff line change
Expand Up @@ -328,12 +328,12 @@ impl JsExpr {
}
#[napi]
pub fn backward_fill(&self) -> JsExpr {
self.clone().inner.backward_fill().into()
self.clone().inner.backward_fill(None).into()
}

#[napi]
pub fn forward_fill(&self) -> JsExpr {
self.clone().inner.forward_fill().into()
self.clone().inner.forward_fill(None).into()
}

#[napi]
Expand Down

0 comments on commit 322f1ed

Please sign in to comment.