fix[rust]: break infinite loop in type coercion optimizer (#4653)

pola-rs · Sep 1, 2022 · 4dcf204 · 4dcf204
1 parent 4cd98b3
commit 4dcf204
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/polars/polars-lazy/src/dsl/function_expr/is_in.rs b/polars/polars-lazy/src/dsl/function_expr/is_in.rs
@@ -3,7 +3,6 @@ use super::*;
 pub(super) fn is_in(s: &mut [Series]) -> Result<Series> {
     let left = &s[0];
     let other = &s[1];
-    dbg!(left, other);
 
     left.is_in(other).map(|ca| ca.into_series())
 }
diff --git a/polars/polars-lazy/src/logical_plan/optimizer/type_coercion.rs b/polars/polars-lazy/src/logical_plan/optimizer/type_coercion.rs
@@ -423,11 +423,15 @@ impl OptimizationRule for TypeCoercionRule {
                 let super_type = get_supertype(&type_left, &type_fill_value).ok()?;
                 let super_type =
                     modify_supertype(super_type, left, fill_value, &type_left, &type_fill_value);
-                Some(AExpr::Function {
-                    function: FunctionExpr::FillNull { super_type },
-                    input: input.clone(),
-                    options,
-                })
+                if super_type != DataType::Unknown {
+                    Some(AExpr::Function {
+                        function: FunctionExpr::FillNull { super_type },
+                        input: input.clone(),
+                        options,
+                    })
+                } else {
+                    None
+                }
             }
             // generic type coercion of any function.
             AExpr::Function {