fix(rust): tag IntoSeries trait as unsafe (#5258)

pola-rs · Oct 19, 2022 · 5a1c744 · 5a1c744
1 parent 598401b
commit 5a1c744
Show file tree

Hide file tree

Showing 7 changed files with 16 additions and 9 deletions.
diff --git a/polars/polars-core/src/series/from.rs b/polars/polars-core/src/series/from.rs
@@ -479,7 +479,14 @@ impl TryFrom<(&str, ArrayRef)> for Series {
     }
 }
 
-pub trait IntoSeries {
+/// Used to convert a [`ChunkedArray`], `&dyn SeriesTrait` and [`Series`]
+/// into a [`Series`].
+/// # Safety
+///
+/// This trait is marked `unsafe` as the `is_series` return is used
+/// to transmute to `Series`. This must always return `false` except
+/// for `Series` structs.
+pub unsafe trait IntoSeries {
     fn is_series() -> bool {
         false
     }
@@ -527,13 +534,13 @@ impl From<TimeChunked> for Series {
     }
 }
 
-impl IntoSeries for Arc<dyn SeriesTrait> {
+unsafe impl IntoSeries for Arc<dyn SeriesTrait> {
     fn into_series(self) -> Series {
         Series(self)
     }
 }
 
-impl IntoSeries for Series {
+unsafe impl IntoSeries for Series {
     fn is_series() -> bool {
         true
     }

diff --git a/polars/polars-core/src/series/implementations/categorical.rs b/polars/polars-core/src/series/implementations/categorical.rs
@@ -16,7 +16,7 @@ use crate::frame::hash_join::ZipOuterJoinColumn;
 use crate::prelude::*;
 use crate::series::implementations::SeriesWrap;
 
-impl IntoSeries for CategoricalChunked {
+unsafe impl IntoSeries for CategoricalChunked {
     fn into_series(self) -> Series {
         Series(Arc::new(SeriesWrap(self)))
     }

diff --git a/polars/polars-core/src/series/implementations/dates_time.rs b/polars/polars-core/src/series/implementations/dates_time.rs
@@ -24,7 +24,7 @@ use crate::prelude::*;
 
 macro_rules! impl_dyn_series {
     ($ca: ident, $into_logical: ident) => {
-        impl IntoSeries for $ca {
+        unsafe impl IntoSeries for $ca {
             fn into_series(self) -> Series {
                 Series(Arc::new(SeriesWrap(self)))
             }

diff --git a/polars/polars-core/src/series/implementations/datetime.rs b/polars/polars-core/src/series/implementations/datetime.rs
@@ -11,7 +11,7 @@ use crate::frame::groupby::*;
 use crate::frame::hash_join::*;
 use crate::prelude::*;
 
-impl IntoSeries for DatetimeChunked {
+unsafe impl IntoSeries for DatetimeChunked {
     fn into_series(self) -> Series {
         Series(Arc::new(SeriesWrap(self)))
     }

diff --git a/polars/polars-core/src/series/implementations/duration.rs b/polars/polars-core/src/series/implementations/duration.rs
@@ -12,7 +12,7 @@ use crate::frame::groupby::*;
 use crate::frame::hash_join::*;
 use crate::prelude::*;
 
-impl IntoSeries for DurationChunked {
+unsafe impl IntoSeries for DurationChunked {
     fn into_series(self) -> Series {
         Series(Arc::new(SeriesWrap(self)))
     }

diff --git a/polars/polars-core/src/series/implementations/mod.rs b/polars/polars-core/src/series/implementations/mod.rs
@@ -61,7 +61,7 @@ impl<T: PolarsDataType> Deref for SeriesWrap<ChunkedArray<T>> {
     }
 }
 
-impl<T: PolarsDataType + 'static> IntoSeries for ChunkedArray<T>
+unsafe impl<T: PolarsDataType + 'static> IntoSeries for ChunkedArray<T>
 where
     SeriesWrap<ChunkedArray<T>>: SeriesTrait,
 {

diff --git a/polars/polars-core/src/series/implementations/struct_.rs b/polars/polars-core/src/series/implementations/struct_.rs
@@ -4,7 +4,7 @@ use super::*;
 use crate::prelude::*;
 use crate::series::private::{PrivateSeries, PrivateSeriesNumeric};
 
-impl IntoSeries for StructChunked {
+unsafe impl IntoSeries for StructChunked {
     fn into_series(self) -> Series {
         Series(Arc::new(SeriesWrap(self)))
     }