python fix time divide by zero (#3838)

pola-rs · Jun 28, 2022 · 65826c0 · 65826c0
1 parent a15b6b1
commit 65826c0
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 0 deletions.
diff --git a/polars/tests/it/lazy/groupby.rs b/polars/tests/it/lazy/groupby.rs
@@ -1,4 +1,5 @@
 use super::*;
+use polars_core::series::ops::NullBehavior;
 
 #[test]
 fn test_filter_sort_diff_2984() -> Result<()> {

diff --git a/py-polars/polars/utils.py b/py-polars/polars/utils.py
@@ -150,6 +150,8 @@ def handle_projection_columns(
 
 
 def _to_python_time(value: int) -> time:
+    if value == 0:
+        return time(microsecond=0)
     value = value // 1_000
     microsecond = value
     seconds = (microsecond // 1000_000) % 60

diff --git a/py-polars/tests/test_datelike.py b/py-polars/tests/test_datelike.py
@@ -1204,3 +1204,7 @@ def test_sorted_unique() -> None:
         .sort("dt")
         .unique()
     ).to_dict(False) == {"dt": [date(2015, 6, 23), date(2015, 6, 24)]}
+
+
+def test_time_zero_3828() -> None:
+    assert pl.Series(values=[time(0)], dtype=pl.Time).to_list() == [time(0)]