refactor(python): deprecate name argument in drop (#5099)

py-polars/polars/internals/dataframe/frame.py

@@ -4218,13 +4218,14 @@ def extend(self: DF, other: DF) -> DF:
         self._df.extend(other._df)
         return self
 
-    def drop(self: DF, name: str | list[str]) -> DF:
+    @deprecated_alias(name="columns")
+    def drop(self: DF, columns: str | list[str]) -> DF:
         """
         Remove column from DataFrame and return as new.
 
         Parameters
         ----------
-        name
+        columns
             Column(s) to drop.
 
         Examples
@@ -4251,14 +4252,14 @@ def drop(self: DF, name: str | list[str]) -> DF:
         └─────┴─────┘
 
         """
-        if isinstance(name, list):
+        if isinstance(columns, list):
             df = self.clone()
 
-            for n in name:
+            for n in columns:
                 df._df.drop_in_place(n)
             return df
 
-        return self._from_pydf(self._df.drop(name))
+        return self._from_pydf(self._df.drop(columns))
 
     def drop_in_place(self, name: str) -> pli.Series:
         """

py-polars/tests/unit/test_df.py

@@ -674,7 +674,10 @@ def test_extend() -> None:
 
 def test_drop() -> None:
     df = pl.DataFrame({"a": [2, 1, 3], "b": ["a", "b", "c"], "c": [1, 2, 3]})
-    df = df.drop("a")
+    df = df.drop(name="a")  # type: ignore[call-arg]
+    assert df.shape == (3, 2)
+    df = pl.DataFrame({"a": [2, 1, 3], "b": ["a", "b", "c"], "c": [1, 2, 3]})
+    df = df.drop(columns="a")
     assert df.shape == (3, 2)
     df = pl.DataFrame({"a": [2, 1, 3], "b": ["a", "b", "c"], "c": [1, 2, 3]})
     s = df.drop_in_place("a")