Remove duplicate impl

pola-rs · Jan 17, 2024 · 72aa951 · 72aa951
1 parent 13d5295
commit 72aa951
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/crates/polars-plan/src/dsl/arithmetic.rs b/crates/polars-plan/src/dsl/arithmetic.rs
@@ -1,4 +1,6 @@
-use std::ops::{Add, Div, Mul, Neg, Rem, Sub};
+#[cfg(feature = "negate")]
+use std::ops::Neg;
+use std::ops::{Add, Div, Mul, Rem, Sub};
 
 use super::*;
 
@@ -43,6 +45,7 @@ impl Rem for Expr {
     }
 }
 
+#[cfg(feature = "negate")]
 impl Neg for Expr {
     type Output = Expr;
 

diff --git a/crates/polars-plan/src/dsl/mod.rs b/crates/polars-plan/src/dsl/mod.rs
@@ -162,12 +162,6 @@ impl Expr {
         binary_expr(self, Operator::LtEq, other.into())
     }
 
-    /// Negate `Expr`.
-    #[allow(clippy::should_implement_trait)]
-    pub fn not(self) -> Expr {
-        self.map_private(BooleanFunction::Not.into())
-    }
-
     /// Rename Column.
     pub fn alias(self, name: &str) -> Expr {
         Expr::Alias(Box::new(self), Arc::from(name))

diff --git a/crates/polars-plan/src/dsl/unary.rs b/crates/polars-plan/src/dsl/unary.rs
@@ -6,7 +6,6 @@ use crate::dsl::Expr;
 impl Not for Expr {
     type Output = Expr;
 
-    #[allow(clippy::should_implement_trait)]
     fn not(self) -> Expr {
         self.map_private(BooleanFunction::Not.into())
     }