order params by length, dtype`

pola-rs · Dec 1, 2023 · 77881ef · 77881ef
1 parent 6ddbb73
commit 77881ef
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/crates/polars-core/src/chunked_array/ops/arity.rs b/crates/polars-core/src/chunked_array/ops/arity.rs
@@ -592,7 +592,7 @@ where
             || (rhs.len() == 1 && rhs.downcast_get_unchecked(0).is_null_unchecked(0))
     } {
         let broadcast_to = lhs.len().max(rhs.len());
-        let arr = StaticArray::full_null(V::get_dtype(), broadcast_to);
+        let arr = StaticArray::full_null(broadcast_to, V::get_dtype());
         return ChunkedArray::with_chunk(lhs.name(), arr);
     }
 
@@ -626,7 +626,7 @@ where
             || (rhs.len() == 1 && rhs.downcast_get_unchecked(0).is_null_unchecked(0))
     } {
         let broadcast_to = lhs.len().max(rhs.len());
-        let arr = StaticArray::full_null(V::get_dtype(), broadcast_to);
+        let arr = StaticArray::full_null(broadcast_to, V::get_dtype());
         return Ok(ChunkedArray::with_chunk(lhs.name(), arr));
     }
 

diff --git a/crates/polars-core/src/datatypes/static_array.rs b/crates/polars-core/src/datatypes/static_array.rs
@@ -78,7 +78,7 @@ pub trait StaticArray:
         v.into_iter().collect_arr_with_dtype(dtype)
     }
 
-    fn full_null(dtype: DataType, length: usize) -> Self {
+    fn full_null(length: usize, dtype: DataType) -> Self {
         unsafe {
             std::ptr::read(Box::into_raw(new_null_array(dtype.to_arrow(), length))
                 as *const dyn Array as *const Self)