Raise error in sample() if n and frac are both passed (#3091)

pola-rs · Apr 8, 2022 · 806b63f · 806b63f
1 parent 0136482
commit 806b63f
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/py-polars/polars/internals/frame.py b/py-polars/polars/internals/frame.py
@@ -4766,6 +4766,9 @@ def sample(
         └─────┴─────┴─────┘
 
         """
+        if n is not None and frac is not None:
+            raise ValueError("n and frac were both supplied")
+
         if n is None and frac is not None:
             return self._from_pydf(self._df.sample_frac(frac, with_replacement, seed))
 

diff --git a/py-polars/polars/internals/series.py b/py-polars/polars/internals/series.py
@@ -3045,6 +3045,9 @@ def sample(
         ]
 
         """
+        if n is not None and frac is not None:
+            raise ValueError("n and frac were both supplied")
+
         if n is None and frac is not None:
             return wrap_s(self._s.sample_frac(frac, with_replacement, seed))