chore: update to rustc nightly-2022-11-24 (#5616)

.github/deploy_manylinux.sh

@@ -8,7 +8,7 @@ ls -la
 rm py-polars/README.md
 cp README.md py-polars/README.md
 cd py-polars
-rustup override set nightly-2022-11-03
+rustup override set nightly-2022-11-24
 export RUSTFLAGS='-C target-feature=+fxsr,+sse,+sse2,+sse3,+ssse3,+sse4.1,+sse4.2,+popcnt,+avx,+fma'
 
 # first the default release

.github/workflows/benchmark.yaml

@@ -50,7 +50,7 @@ jobs:
       - name: Set up Rust
         uses: dtolnay/rust-toolchain@master
         with:
-          toolchain: nightly-2022-11-03
+          toolchain: nightly-2022-11-24
 
       - name: Cache Rust
         uses: Swatinem/rust-cache@v2

.github/workflows/build-test-rust.yaml

@@ -34,7 +34,7 @@ jobs:
       - name: Set up Rust
         uses: dtolnay/rust-toolchain@master
         with:
-          toolchain: nightly-2022-11-03
+          toolchain: nightly-2022-11-24
 
       - name: Cache Rust
         uses: Swatinem/rust-cache@v2
@@ -58,7 +58,7 @@ jobs:
       - name: Set up Rust
         uses: dtolnay/rust-toolchain@master
         with:
-          toolchain: nightly-2022-11-03
+          toolchain: nightly-2022-11-24
           components: rustfmt, clippy, miri
 
       - name: Cache Rust
@@ -102,7 +102,7 @@ jobs:
       - name: Set up Rust
         uses: dtolnay/rust-toolchain@master
         with:
-          toolchain: nightly-2022-11-03
+          toolchain: nightly-2022-11-24
 
       - name: Cache Rust
         uses: Swatinem/rust-cache@v2

.github/workflows/create-python-release.yaml

@@ -29,7 +29,7 @@ jobs:
           MATURIN_PASSWORD: ${{ secrets.PYPI_PASS }}
           RUSTFLAGS: -C target-feature=+fxsr,+sse,+sse2,+sse3,+ssse3,+sse4.1,+sse4.2,+popcnt,+avx,+fma
         with:
-          rust-toolchain: nightly-2022-11-03
+          rust-toolchain: nightly-2022-11-24
           maturin-version: '0.13.5'
           command: publish
           args: -m py-polars/Cargo.toml --skip-existing -o wheels -u ritchie46
@@ -53,7 +53,7 @@ jobs:
         env:
           MATURIN_PASSWORD: ${{ secrets.PYPI_PASS }}
         with:
-          rust-toolchain: nightly-2022-11-03
+          rust-toolchain: nightly-2022-11-24
           target: aarch64-unknown-linux-gnu
           maturin-version: '0.13.5'
           command: publish
@@ -84,7 +84,7 @@ jobs:
           MATURIN_PASSWORD: ${{ secrets.PYPI_PASS }}
           RUSTFLAGS: -C target-feature=+fxsr,+sse,+sse2,+sse3,+ssse3,+sse4.1,+sse4.2,+popcnt,+avx,+fma
         with:
-          rust-toolchain: nightly-2022-11-03
+          rust-toolchain: nightly-2022-11-24
           maturin-version: '0.13.5'
           command: publish
           args: -m py-polars/Cargo.toml --skip-existing -o wheels -u ritchie46
@@ -111,7 +111,7 @@ jobs:
           MATURIN_PASSWORD: ${{ secrets.PYPI_PASS }}
           RUSTFLAGS: -C target-feature=+fxsr,+sse,+sse2,+sse3,+ssse3,+sse4.1,+sse4.2,+popcnt --cfg use_mimalloc
         with:
-          rust-toolchain: nightly-2022-11-03
+          rust-toolchain: nightly-2022-11-24
           maturin-version: '0.13.5'
           command: publish
           args: -m py-polars/Cargo.toml --skip-existing -o wheels -u ritchie46
@@ -140,7 +140,7 @@ jobs:
           MATURIN_PASSWORD: ${{ secrets.PYPI_PASS }}
           RUSTFLAGS: -C target-feature=+fxsr,+sse,+sse2,+sse3,+sse4.1,+sse4.2
         with:
-          rust-toolchain: nightly-2022-11-03
+          rust-toolchain: nightly-2022-11-24
           maturin-version: '0.13.5'
           command: publish
           args: -m py-polars/Cargo.toml --no-sdist --skip-existing -o wheels -i python -u ritchie46
@@ -161,7 +161,7 @@ jobs:
       - name: Set up Rust
         uses: dtolnay/rust-toolchain@master
         with:
-          toolchain: nightly-2022-11-03
+          toolchain: nightly-2022-11-24
 
       - name: Set up Rust targets
         run: rustup target add aarch64-apple-darwin
@@ -193,7 +193,7 @@ jobs:
   #     - name: Set up Rust
   #       uses: dtolnay/rust-toolchain@master
   #       with:
-  #         toolchain: nightly-2022-11-03
+  #         toolchain: nightly-2022-11-24
 
   #     - name: Set up Rust targets
   #       run: rustup target add aarch64-apple-darwin

.github/workflows/docs-deploy.yaml

@@ -30,7 +30,7 @@ jobs:
       - name: Set up Rust
         uses: dtolnay/rust-toolchain@master
         with:
-          toolchain: nightly-2022-11-03
+          toolchain: nightly-2022-11-24
           components: rust-docs
 
       - name: Cache Rust

.github/workflows/lint-python.yaml

@@ -39,7 +39,7 @@ jobs:
       - name: Set up Rust
         uses: dtolnay/rust-toolchain@master
         with:
-          toolchain: nightly-2022-11-03
+          toolchain: nightly-2022-11-24
           components: rustfmt, clippy
       - name: Cache Rust
         uses: Swatinem/rust-cache@v2

.github/workflows/test-python.yaml

@@ -50,7 +50,7 @@ jobs:
       - name: Set up Rust
         uses: dtolnay/rust-toolchain@master
         with:
-          toolchain: nightly-2022-11-03
+          toolchain: nightly-2022-11-24
 
       - name: Cache Rust
         uses: Swatinem/rust-cache@v2
@@ -112,7 +112,7 @@ jobs:
       - name: Set up Rust
         uses: dtolnay/rust-toolchain@master
         with:
-          toolchain: nightly-2022-11-03
+          toolchain: nightly-2022-11-24
 
       - name: Cache Rust
         uses: Swatinem/rust-cache@v2

polars/polars-core/src/datatypes/any_value.rs

@@ -548,7 +548,7 @@ impl<'a> AnyValue<'a> {
     }
 
     #[must_use]
-    pub fn add<'b>(&self, rhs: &AnyValue<'b>) -> Self {
+    pub fn add(&self, rhs: &AnyValue) -> Self {
         use AnyValue::*;
         match (self, rhs) {
             (Null, _) => Null,

polars/polars-core/src/frame/groupby/expr.rs

@@ -2,7 +2,7 @@ use crate::prelude::*;
 
 pub trait PhysicalAggExpr {
     #[allow(clippy::ptr_arg)]
-    fn evaluate<'a>(&self, df: &DataFrame, groups: &'a GroupsProxy) -> PolarsResult<Series>;
+    fn evaluate(&self, df: &DataFrame, groups: &GroupsProxy) -> PolarsResult<Series>;
 
     fn root_name(&self) -> PolarsResult<&str>;
 }

polars/polars-core/src/series/any_value.rs

@@ -74,9 +74,9 @@ impl<'a, T: AsRef<[AnyValue<'a>]>> NamedFrom<T, [AnyValue<'a>]> for Series {
 }
 
 impl Series {
-    pub fn from_any_values_and_dtype<'a>(
+    pub fn from_any_values_and_dtype(
         name: &str,
-        av: &[AnyValue<'a>],
+        av: &[AnyValue],
         dtype: &DataType,
     ) -> PolarsResult<Series> {
         let mut s = match dtype {
@@ -166,7 +166,7 @@ impl Series {
         Ok(s)
     }
 
-    pub fn from_any_values<'a>(name: &str, av: &[AnyValue<'a>]) -> PolarsResult<Series> {
+    pub fn from_any_values(name: &str, av: &[AnyValue]) -> PolarsResult<Series> {
         match av.iter().find(|av| !matches!(av, AnyValue::Null)) {
             None => Ok(Series::full_null(name, av.len(), &DataType::Int32)),
             Some(av_) => {

polars/polars-core/src/series/mod.rs

@@ -478,8 +478,7 @@ impl Series {
 
     /// Take by index. This operation is clone.
     ///
-    /// # Safety
-    ///
+    /// # Notes
     /// Out of bounds access doesn't Error but will return a Null value
     pub fn take_threaded(&self, idx: &IdxCa, rechunk: bool) -> PolarsResult<Series> {
         self.threaded_op(rechunk, idx.len(), &|offset, len| {

polars/polars-io/src/ndjson_core/buffer.rs

@@ -250,7 +250,7 @@ fn value_to_dtype(val: &Value) -> DataType {
     }
 }
 
-fn deserialize_all<'a, 'b>(json: &'b Value) -> AnyValue<'a> {
+fn deserialize_all<'a>(json: &Value) -> AnyValue<'a> {
     match json {
         Value::Static(StaticNode::Bool(b)) => AnyValue::Boolean(*b),
         Value::Static(StaticNode::I64(i)) => AnyValue::Int64(*i),

polars/polars-io/src/ndjson_core/ndjson.rs

@@ -247,9 +247,9 @@ impl<'a> CoreJsonReader<'a> {
 }
 
 #[inline(always)]
-fn parse_impl<'a>(
+fn parse_impl(
     bytes: &[u8],
-    buffers: &mut PlIndexMap<BufferKey, Buffer<'a>>,
+    buffers: &mut PlIndexMap<BufferKey, Buffer>,
     line: &mut Vec<u8>,
 ) -> PolarsResult<usize> {
     line.clear();
@@ -299,10 +299,7 @@ fn parse_impl<'a>(
     }
 }
 
-fn parse_lines<'a>(
-    bytes: &[u8],
-    buffers: &mut PlIndexMap<BufferKey, Buffer<'a>>,
-) -> PolarsResult<()> {
+fn parse_lines(bytes: &[u8], buffers: &mut PlIndexMap<BufferKey, Buffer>) -> PolarsResult<()> {
     let mut buf = vec![];
 
     let total_bytes = bytes.len();

polars/polars-lazy/polars-plan/src/logical_plan/builder.rs

@@ -1,4 +1,4 @@
-use std::io::{Read, Seek, SeekFrom};
+use std::io::{Read, Seek};
 use std::ops::Deref;
 use std::path::PathBuf;
 use std::sync::Mutex;
@@ -194,7 +194,7 @@ impl LogicalPlanBuilder {
                 "cannot scan compressed csv; use read_csv for compressed data".into(),
             ));
         }
-        file.seek(SeekFrom::Start(0))?;
+        file.rewind()?;
         let reader_bytes = get_reader_bytes(&mut file).expect("could not mmap file");
 
         // TODO! delay inferring schema until absolutely necessary

polars/polars-lazy/src/frame/pivot.rs

@@ -17,7 +17,7 @@ use crate::prelude::*;
 struct PivotExpr(Expr);
 
 impl PhysicalAggExpr for PivotExpr {
-    fn evaluate<'a>(&self, df: &DataFrame, groups: &'a GroupsProxy) -> PolarsResult<Series> {
+    fn evaluate(&self, df: &DataFrame, groups: &GroupsProxy) -> PolarsResult<Series> {
         let state = ExecutionState::new();
         let dtype = df.get_columns()[0].dtype();
         let phys_expr = prepare_expression_for_context("", &self.0, dtype, Context::Aggregation)?;

rust-toolchain.toml

@@ -1,2 +1,2 @@
 [toolchain]
-channel = "nightly-2022-11-03"
+channel = "nightly-2022-11-24"