python: respect dtype in create from numpy array (#2899)

pola-rs · Mar 15, 2022 · 9b74fc7 · 9b74fc7
1 parent bfbedfa
commit 9b74fc7
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 10 deletions.
diff --git a/py-polars/Cargo.lock b/py-polars/Cargo.lock
diff --git a/py-polars/polars/internals/series.py b/py-polars/polars/internals/series.py
@@ -219,6 +219,8 @@ def __init__(
             self._s = arrow_to_pyseries(name, values)
         elif isinstance(values, np.ndarray):
             self._s = numpy_to_pyseries(name, values, strict, nan_to_null)
+            if dtype is not None:
+                self._s = self.cast(dtype, strict=True)._s
         elif isinstance(values, Sequence):
             self._s = sequence_to_pyseries(name, values, dtype=dtype, strict=strict)
         elif _PANDAS_AVAILABLE and isinstance(values, (pd.Series, pd.DatetimeIndex)):

diff --git a/py-polars/src/npy.rs b/py-polars/src/npy.rs
@@ -42,14 +42,6 @@ pub unsafe fn aligned_array<T: Element + NativeType>(
     );
     (PyArray1::from_owned_ptr(py, ptr), buf)
 }
-/// TODO: needs more explanation
-/// # Safety
-///
-/// Create a vector from raw parts.
-pub unsafe fn vec_from_ptr<T>(ptr: usize, len: usize) -> Vec<T> {
-    let ptr = ptr as *mut T;
-    Vec::from_raw_parts(ptr, len, len)
-}
 
 /// Get reference counter for numpy arrays.
 ///   - For CPython: Get reference counter.

diff --git a/py-polars/tests/test_interop.py b/py-polars/tests/test_interop.py
@@ -262,3 +262,7 @@ def test_from_null_column() -> None:
 
 def test_to_pandas_series() -> None:
     assert (pl.Series("a", [1, 2, 3]).to_pandas() == pd.Series([1, 2, 3])).all()
+
+
+def test_respect_dtype_with_series_from_numpy() -> None:
+    assert pl.Series("foo", np.array([1, 2, 3]), dtype=pl.UInt32).dtype == pl.UInt32