fix: use use pytest.approx to compare float in rolling_skew test (#4300)

pola-rs · Aug 8, 2022 · 9fcf4ac · 9fcf4ac
1 parent 6d08df0
commit 9fcf4ac
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 20 deletions.
diff --git a/polars/polars-arrow/src/utils.rs b/polars/polars-arrow/src/utils.rs
@@ -52,7 +52,7 @@ pub fn combine_validities(opt_l: Option<&Bitmap>, opt_r: Option<&Bitmap>) -> Opt
     match (opt_l, opt_r) {
         (Some(l), Some(r)) => Some(l.bitand(r)),
         (None, Some(r)) => Some(r.clone()),
-        (Some(l), None) => (Some(l.clone())),
+        (Some(l), None) => Some(l.clone()),
         (None, None) => None,
     }
 }

diff --git a/polars/polars-core/src/series/ops/moment.rs b/polars/polars-core/src/series/ops/moment.rs
@@ -62,7 +62,7 @@ impl Series {
 
         if !bias {
             let n = self.len() as f64;
-            Ok(Some(((n - 1.0) * n).sqrt() / (n - 2.0) * m3 / m2.powf(1.5)))
+            Ok(Some(((n - 1.0) * n).sqrt() / (n - 2.0) * out))
         } else {
             Ok(Some(out))
         }

diff --git a/py-polars/tests/test_rolling.py b/py-polars/tests/test_rolling.py
@@ -3,6 +3,8 @@
 from datetime import datetime
 from typing import TYPE_CHECKING
 
+import pytest
+
 import polars as pl
 
 if TYPE_CHECKING:
@@ -57,22 +59,26 @@ def test_rolling_kernels_and_groupby_rolling() -> None:
 
 def test_rolling_skew() -> None:
     s = pl.Series([1, 2, 3, 3, 2, 10, 8])
-    assert s.rolling_skew(window_size=4, bias=True).to_list() == [
-        None,
-        None,
-        None,
-        -0.49338220021815865,
-        0.0,
-        1.097025449363867,
-        0.09770939201338157,
-    ]
+    assert s.rolling_skew(window_size=4, bias=True).to_list() == pytest.approx(
+        [
+            None,
+            None,
+            None,
+            -0.49338220021815865,
+            0.0,
+            1.097025449363867,
+            0.09770939201338157,
+        ]
+    )
 
-    assert s.rolling_skew(window_size=4, bias=False).to_list() == [
-        None,
-        None,
-        None,
-        -0.8545630383279711,
-        0.0,
-        1.9001038154942962,
-        0.16923763134384154,
-    ]
+    assert s.rolling_skew(window_size=4, bias=False).to_list() == pytest.approx(
+        [
+            None,
+            None,
+            None,
+            -0.8545630383279711,
+            0.0,
+            1.9001038154942962,
+            0.16923763134384154,
+        ]
+    )