py: default sample n param to 1 (#3090)

pola-rs · Apr 8, 2022 · ca5208f · ca5208f
1 parent 91d7a0c
commit ca5208f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/py-polars/polars/internals/frame.py b/py-polars/polars/internals/frame.py
@@ -4763,9 +4763,13 @@ def sample(
         └─────┴─────┴─────┘
 
         """
-        if n is not None:
-            return self._from_pydf(self._df.sample_n(n, with_replacement, seed))
-        return self._from_pydf(self._df.sample_frac(frac, with_replacement, seed))
+        if n is None and frac is not None:
+            return self._from_pydf(self._df.sample_frac(frac, with_replacement, seed))
+
+        if n is None:
+            n = 1
+
+        return self._from_pydf(self._df.sample_n(n, with_replacement, seed))
 
     def fold(
         self, operation: Callable[["pli.Series", "pli.Series"], "pli.Series"]

diff --git a/py-polars/polars/internals/series.py b/py-polars/polars/internals/series.py
@@ -3045,9 +3045,13 @@ def sample(
         ]
 
         """
-        if n is not None:
-            return wrap_s(self._s.sample_n(n, with_replacement, seed))
-        return wrap_s(self._s.sample_frac(frac, with_replacement, seed))
+        if n is None and frac is not None:
+            return wrap_s(self._s.sample_frac(frac, with_replacement, seed))
+
+        if n is None:
+            n = 1
+
+        return wrap_s(self._s.sample_n(n, with_replacement, seed))
 
     def peak_max(self) -> "Series":
         """