refactor[rust]: remove agg_median from series trait (#4963)

pola-rs · Sep 24, 2022 · d12be1c · d12be1c
1 parent d960c03
commit d12be1c
Show file tree

Hide file tree

Showing 8 changed files with 28 additions and 29 deletions.
diff --git a/polars/polars-core/src/datatypes/dtype.rs b/polars/polars-core/src/datatypes/dtype.rs
@@ -126,6 +126,12 @@ impl DataType {
         self != &self.to_physical()
     }
 
+    /// Check if this [`DataType`] is a temporal type
+    pub fn is_temporal(&self) -> bool {
+        use DataType::*;
+        matches!(self, Date | Datetime(_, _) | Duration(_) | Time)
+    }
+
     /// Check if this [`DataType`] is a numeric type
     pub fn is_numeric(&self) -> bool {
         // allow because it cannot be replaced when object feature is activated

diff --git a/polars/polars-core/src/frame/groupby/aggregations/mod.rs b/polars/polars-core/src/frame/groupby/aggregations/mod.rs
@@ -300,6 +300,27 @@ impl Series {
         }
     }
 
+    #[doc(hidden)]
+    pub unsafe fn agg_median(&self, groups: &GroupsProxy) -> Series {
+        use DataType::*;
+
+        match self.dtype() {
+            Float32 => SeriesWrap(self.f32().unwrap().clone()).agg_median(groups),
+            Float64 => SeriesWrap(self.f64().unwrap().clone()).agg_median(groups),
+            dt if dt.is_numeric() || dt.is_temporal() => {
+                let ca = self.to_physical_repr();
+                let s = apply_method_physical_integer!(ca, agg_median, groups);
+                if dt.is_logical() {
+                    // back to logical type
+                    s.cast(dt).unwrap()
+                } else {
+                    s
+                }
+            }
+            _ => Series::full_null("", groups.len(), self.dtype()),
+        }
+    }
+
     #[doc(hidden)]
     pub unsafe fn agg_mean(&self, groups: &GroupsProxy) -> Series {
         use DataType::*;

diff --git a/polars/polars-core/src/series/implementations/dates_time.rs b/polars/polars-core/src/series/implementations/dates_time.rs
@@ -115,10 +115,6 @@ macro_rules! impl_dyn_series {
                     .into_series()
             }
 
-            unsafe fn agg_median(&self, groups: &GroupsProxy) -> Series {
-                self.0.agg_median(groups).$into_logical().into_series()
-            }
-
             fn zip_outer_join_column(
                 &self,
                 right_column: &Series,

diff --git a/polars/polars-core/src/series/implementations/datetime.rs b/polars/polars-core/src/series/implementations/datetime.rs
@@ -115,12 +115,6 @@ impl private::PrivateSeries for SeriesWrap<DatetimeChunked> {
             .into_series()
     }
 
-    unsafe fn agg_median(&self, groups: &GroupsProxy) -> Series {
-        self.0
-            .agg_median(groups)
-            .into_datetime(self.0.time_unit(), self.0.time_zone().clone())
-            .into_series()
-    }
     fn zip_outer_join_column(
         &self,
         right_column: &Series,

diff --git a/polars/polars-core/src/series/implementations/duration.rs b/polars/polars-core/src/series/implementations/duration.rs
@@ -150,16 +150,6 @@ impl private::PrivateSeries for SeriesWrap<DurationChunked> {
             .into_series()
     }
 
-    unsafe fn agg_median(&self, groups: &GroupsProxy) -> Series {
-        self.0
-            .agg_median(groups)
-            // cast f64 back to physical type
-            .cast(&DataType::Int64)
-            .unwrap()
-            .into_duration(self.0.time_unit())
-            .into_series()
-    }
-
     fn zip_outer_join_column(
         &self,
         right_column: &Series,

diff --git a/polars/polars-core/src/series/implementations/floats.rs b/polars/polars-core/src/series/implementations/floats.rs
@@ -120,9 +120,6 @@ macro_rules! impl_dyn_series {
                 self.agg_quantile(groups, quantile, interpol)
             }
 
-            unsafe fn agg_median(&self, groups: &GroupsProxy) -> Series {
-                self.agg_median(groups)
-            }
             fn zip_outer_join_column(
                 &self,
                 right_column: &Series,

diff --git a/polars/polars-core/src/series/implementations/mod.rs b/polars/polars-core/src/series/implementations/mod.rs
@@ -179,9 +179,6 @@ macro_rules! impl_dyn_series {
                 self.0.agg_quantile(groups, quantile, interpol)
             }
 
-            unsafe fn agg_median(&self, groups: &GroupsProxy) -> Series {
-                self.0.agg_median(groups)
-            }
             fn zip_outer_join_column(
                 &self,
                 right_column: &Series,

diff --git a/polars/polars-core/src/series/series_trait.rs b/polars/polars-core/src/series/series_trait.rs
@@ -155,9 +155,7 @@ pub(crate) mod private {
         ) -> Series {
             Series::full_null(self._field().name(), groups.len(), self._dtype())
         }
-        unsafe fn agg_median(&self, groups: &GroupsProxy) -> Series {
-            Series::full_null(self._field().name(), groups.len(), self._dtype())
-        }
+
         fn zip_outer_join_column(
             &self,
             _right_column: &Series,