fix[rust]: strptime should not panic on invalid dates (#4914)

pola-rs · Sep 21, 2022 · da2b06d · da2b06d
1 parent da25686
commit da2b06d
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/polars/polars-time/src/chunkedarray/utf8/strptime.rs b/polars/polars-time/src/chunkedarray/utf8/strptime.rs
@@ -109,7 +109,8 @@ pub(super) unsafe fn parse(val: &[u8], fmt: &[u8], fmt_len: u16) -> Option<Naive
     }
     // all values processed
     if offset == val.len() {
-        Some(NaiveDate::from_ymd(year, month, day).and_hms_nano(hour, min, sec, nano))
+        NaiveDate::from_ymd_opt(year, month, day)
+            .and_then(|nd| nd.and_hms_nano_opt(hour, min, sec, nano))
     }
     // remaining values did not match pattern
     else {

diff --git a/py-polars/tests/unit/test_datelike.py b/py-polars/tests/unit/test_datelike.py
@@ -1500,3 +1500,9 @@ def test_short_formats() -> None:
 def test_iso_year() -> None:
     dt = datetime(2022, 1, 1, 7, 8, 40)
     assert pl.Series([dt]).dt.iso_year()[0] == 2021
+
+
+def test_invalid_date_parsing_4898() -> None:
+    assert pl.Series(["2022-09-18", "2022-09-50"]).str.strptime(
+        pl.Date, "%Y-%m-%d", strict=False
+    ).to_list() == [date(2022, 9, 18), None]