fix(rust, python): fix invalid boolean simplification (#5976)

pola-rs · Jan 1, 2023 · dc67fd0 · dc67fd0
1 parent ab317c7
commit dc67fd0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/polars/polars-lazy/polars-plan/src/logical_plan/optimizer/simplify_expr.rs b/polars/polars-lazy/polars-plan/src/logical_plan/optimizer/simplify_expr.rs
@@ -176,6 +176,7 @@ impl OptimizationRule for SimplifyBooleanRule {
             }
             // x or false => x
             AExpr::BinaryExpr {
+                left,
                 op: Operator::Or,
                 right,
                 ..
@@ -184,7 +185,7 @@ impl OptimizationRule for SimplifyBooleanRule {
                 AExpr::Literal(LiteralValue::Boolean(false))
             ) =>
             {
-                Some(expr_arena.get(*right).clone())
+                Some(expr_arena.get(*left).clone())
             }
 
             // false OR x => x

diff --git a/py-polars/tests/unit/test_filter.py b/py-polars/tests/unit/test_filter.py
@@ -93,3 +93,13 @@ def test_predicate_order_explode_5950() -> None:
         .filter(pl.col("n").count().over(["i"]) == 2)
         .filter(pl.col("n").is_not_null())
     ).collect().to_dict(False) == {"i": [1], "n": [0]}
+
+
+def test_binary_simplification_5971() -> None:
+    df = pl.DataFrame(pl.Series("a", [1, 2, 3, 4]))
+    assert df.select((pl.col("a") > 2) | pl.lit(False))["a"].to_list() == [
+        False,
+        False,
+        True,
+        True,
+    ]