More delimiter to sep (#1426)

polars/polars-lazy/src/functions.rs

@@ -85,10 +85,10 @@ pub fn argsort_by(by: Vec<Expr>, reverse: &[bool]) -> Expr {
 #[cfg(feature = "concat_str")]
 #[cfg_attr(docsrs, doc(cfg(feature = "concat_str")))]
 /// Concat string columns in linear time
-pub fn concat_str(s: Vec<Expr>, delimiter: &str) -> Expr {
-    let delimiter = delimiter.to_string();
+pub fn concat_str(s: Vec<Expr>, sep: &str) -> Expr {
+    let sep = sep.to_string();
     let function = NoEq::new(Arc::new(move |s: &mut [Series]| {
-        polars_core::functions::concat_str(s, &delimiter).map(|ca| ca.into_series())
+        polars_core::functions::concat_str(s, &sep).map(|ca| ca.into_series())
     }) as Arc<dyn SeriesUdf>);
     Expr::Function {
         input: s,

py-polars/polars/eager/frame.py

@@ -790,7 +790,7 @@ def to_csv(
         >>>     "bar": [6, 7, 8, 9, 10],
         >>>     "ham": ['a', 'b', 'c', 'd','e']
         >>>     })
-        >>> df.to_csv('new_file.csv', delimiter=',')
+        >>> df.to_csv('new_file.csv', sep=',')
 
         """
         if file is None:

py-polars/polars/lazy/functions.py

@@ -624,22 +624,22 @@ def argsort_by(
     return pl.lazy.expr.wrap_expr(pyargsort_by(exprs, reverse))
 
 
-def concat_str(exprs: tp.List["pl.Expr"], delimiter: str = "") -> "pl.Expr":
+def concat_str(exprs: tp.List["pl.Expr"], sep: str = "") -> "pl.Expr":
     """
     Concat Utf8 Series in linear time. Non utf8 columns are cast to utf8.
 
     Parameters
     ----------
     exprs
         Columns to concat into a Utf8 Series
-    delimiter
+    sep
         String value that will be used to separate the values.
     """
     exprs = pl.lazy.expr._selection_to_pyexpr_list(exprs)
-    return pl.lazy.expr.wrap_expr(_concat_str(exprs, delimiter))
+    return pl.lazy.expr.wrap_expr(_concat_str(exprs, sep))
 
 
-def concat_list(exprs: tp.List["pl.Expr"], delimiter: str = "") -> "pl.Expr":
+def concat_list(exprs: tp.List["pl.Expr"]) -> "pl.Expr":
     """
     Concat the arrays in a Series dtype List in linear time.
 

py-polars/src/lib.rs

@@ -113,9 +113,9 @@ fn toggle_string_cache(toggle: bool) {
 }
 
 #[pyfunction]
-fn concat_str(s: Vec<dsl::PyExpr>, delimiter: &str) -> dsl::PyExpr {
+fn concat_str(s: Vec<dsl::PyExpr>, sep: &str) -> dsl::PyExpr {
     let s = s.into_iter().map(|e| e.inner).collect();
-    polars::lazy::functions::concat_str(s, delimiter).into()
+    polars::lazy::functions::concat_str(s, sep).into()
 }
 
 #[pyfunction]

py-polars/tests/test_lazy.py

@@ -229,7 +229,7 @@ def test_window_deadlock():
 def test_concat_str():
     df = pl.DataFrame({"a": ["a", "b", "c"], "b": [1, 2, 3]})
 
-    out = df[[pl.concat_str(["a", "b"], delimiter="-")]]
+    out = df[[pl.concat_str(["a", "b"], sep="-")]]
     assert out["a"] == ["a-1", "a-2", "a-3"]