python polars 0.13.28

pola-rs · May 1, 2022 · f3c9898 · f3c9898
1 parent 3bbe110
commit f3c9898
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 9 deletions.
diff --git a/polars/polars-lazy/src/physical_plan/planner/lp.rs b/polars/polars-lazy/src/physical_plan/planner/lp.rs
@@ -366,15 +366,9 @@ impl DefaultPlanner {
                                                 | AAggExpr::Mean(_)
                                                 | AAggExpr::Last(_)
                                                 | AAggExpr::First(_)
-                                                | AAggExpr::Count(_)
                                         )
                                     },
-                                    // TODO: first fix make proper final implementation
-                                    // BinaryExpr {left, right, ..} => {
-                                    //     matches!(expr_arena.get(*left), Literal(_) | Column(_)) &&
-                                    //     matches!(expr_arena.get(*right), Literal(_) | Column(_))
-                                    // }
-                                    Literal(_) | Not(_) | IsNotNull(_) | IsNull(_) | Column(_) | Count | Alias(_, _) => {
+                                    Column(_) | Alias(_, _) => {
                                         true
                                     }
                                     _ => {

diff --git a/polars/polars-lazy/src/tests/queries.rs b/polars/polars-lazy/src/tests/queries.rs
@@ -1959,6 +1959,7 @@ fn test_is_in() -> Result<()> {
 
 #[test]
 fn test_partitioned_gb() -> Result<()> {
+    // don't move these to integration tests
     // keep these dtypes
     let out = df![
         "keys" => [1, 1, 1, 1, 2],
@@ -1981,3 +1982,22 @@ fn test_partitioned_gb() -> Result<()> {
 
     Ok(())
 }
+
+#[test]
+fn test_partitioned_gb_count() -> Result<()> {
+    // don't move these to integration tests
+    let out = df![
+        "col" => (0..100).map(|_| Some(0)).collect::<Int32Chunked>().into_series(),
+    ]?
+    .lazy()
+    .groupby([col("col")])
+    .agg([count().alias("count")])
+    .collect()?;
+
+    assert!(out.frame_equal(&df![
+        "col" => [0],
+        "count" => [100 as IdxSize],
+    ]?));
+
+    Ok(())
+}
diff --git a/py-polars/Cargo.lock b/py-polars/Cargo.lock
diff --git a/py-polars/Cargo.toml b/py-polars/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "py-polars"
-version = "0.13.26"
+version = "0.13.28"
 authors = ["ritchie46 <ritchie46@gmail.com>"]
 documentation = "https://pola-rs.github.io/polars/py-polars/html/reference/index.html"
 edition = "2021"