Skip to content

Commit

Permalink
test(python): Catch deprecation warnings in unit tests (#5306)
Browse files Browse the repository at this point in the history
  • Loading branch information
zundertj committed Oct 23, 2022
1 parent 0e4e2c1 commit fa830b7
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
5 changes: 3 additions & 2 deletions py-polars/tests/unit/test_df.py
Original file line number Diff line number Diff line change
Expand Up @@ -679,8 +679,9 @@ def test_extend() -> None:

def test_drop() -> None:
df = pl.DataFrame({"a": [2, 1, 3], "b": ["a", "b", "c"], "c": [1, 2, 3]})
df = df.drop(name="a") # type: ignore[call-arg]
assert df.shape == (3, 2)
with pytest.deprecated_call():
df = df.drop(name="a") # type: ignore[call-arg]
assert df.shape == (3, 2)
df = pl.DataFrame({"a": [2, 1, 3], "b": ["a", "b", "c"], "c": [1, 2, 3]})
df = df.drop(columns="a")
assert df.shape == (3, 2)
Expand Down
13 changes: 7 additions & 6 deletions py-polars/tests/unit/test_series.py
Original file line number Diff line number Diff line change
Expand Up @@ -385,12 +385,13 @@ def test_various() -> None:

def test_filter_ops() -> None:
a = pl.Series("a", range(20))
assert a[a > 1].len() == 18
assert a[a < 1].len() == 1
assert a[a <= 1].len() == 2
assert a[a >= 1].len() == 19
assert a[a == 1].len() == 1
assert a[a != 1].len() == 19
with pytest.deprecated_call(match="passing a boolean mask to Series.__getitem__"):
assert a[a > 1].len() == 18
assert a[a < 1].len() == 1
assert a[a <= 1].len() == 2
assert a[a >= 1].len() == 19
assert a[a == 1].len() == 1
assert a[a != 1].len() == 19


def test_cast() -> None:
Expand Down

0 comments on commit fa830b7

Please sign in to comment.