Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement all selectors in Rust #10594

Open
ritchie46 opened this issue Aug 18, 2023 · 2 comments
Open

implement all selectors in Rust #10594

ritchie46 opened this issue Aug 18, 2023 · 2 comments
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature rust Related to Rust Polars

Comments

@ritchie46
Copy link
Member

Problem description

The selector API has proven to be a very successful proof of concept.

Now it is time to implement them directly in rust and let the python bindings dispatch to those implementations. This will be faster, have less memory allocations and ensures feature parity between all front-ends.

@alexander-beedie interested in this one? It is a nice rust dabble. :)
@ritchie46 ritchie46 added the enhancement New feature or an improvement of an existing feature label Aug 18, 2023
@alexander-beedie
Copy link
Collaborator

alexander-beedie commented Aug 19, 2023 •
edited

Sure - if you can start me off in the right direction it would be interesting to "promote" them into Rust :)

Going to work on the updates for database connectivity first though (been batting around a few light prototypes and a simple first-cut is starting to take shape).

@stinodego
Copy link
Member

This would be a great addition. I love the selector functionality but strongly dislike having to handle these in every function/method on the Python side.

@stinodego stinodego added accepted Ready for implementation rust Related to Rust Polars labels Aug 19, 2023
Atreyagaurav added a commit to Atreyagaurav/polars-book that referenced this issue Aug 29, 2023
@Atreyagaurav
Add code blocks for column_selections.rs to make the docs run
2ab17bd 
Temporary fix as with the missing blocks the docs refuse to compile
and serve. And the selectors are not available in rust:

pola-rs/polars#10594
@alexander-beedie alexander-beedie mentioned this issue Aug 30, 2023
Merged
stinodego pushed a commit to Atreyagaurav/polars-book that referenced this issue Sep 13, 2023
@Atreyagaurav @stinodego
Add code blocks for column_selections.rs to make the docs run
202bdb4 
Temporary fix as with the missing blocks the docs refuse to compile
and serve. And the selectors are not available in rust:

pola-rs/polars#10594
@etiennebacher etiennebacher mentioned this issue Oct 19, 2023
Closed
@etiennebacher etiennebacher mentioned this issue Nov 26, 2023
Open
@stinodego stinodego mentioned this issue Dec 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature rust Related to Rust Polars
Projects
Backlog
Status: Ready
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexander-beedie @ritchie46 @stinodego